You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/07/24 15:10:04 UTC
[GitHub] [arrow-adbc] lidavidm opened a new issue, #929: format: should we specify anything about signal-safety of the Cancel methods?
lidavidm opened a new issue, #929:
URL: https://github.com/apache/arrow-adbc/issues/929
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] pitrou commented on issue #929: format: should we specify anything about signal-safety of the Cancel methods?
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on issue #929:
URL: https://github.com/apache/arrow-adbc/issues/929#issuecomment-1648150481
I don't think we should require that. Signal-safety is hard to achieve in practice. I'd rather transfer that responsability to the client, if they need to cancel something from a signal handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #929: format: should we specify anything about signal-safety of the Cancel methods?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #929:
URL: https://github.com/apache/arrow-adbc/issues/929#issuecomment-1648134099
Note that I'm talking about other code/user code making a call to AdbcConnectionCancel from a signal handler, not us setting a signal handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] zeroshade commented on issue #929: format: should we specify anything about signal-safety of the Cancel methods?
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #929:
URL: https://github.com/apache/arrow-adbc/issues/929#issuecomment-1648131893
> IMO I don't think we can require AdbcConnectionCancel etc. to be signal-safe, practically...
I know that with Go you can set signal handlers, but I've never tested it across cgo before so I don't know how well that would work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm closed issue #929: format: should we specify anything about signal-safety of the Cancel methods?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed issue #929: format: should we specify anything about signal-safety of the Cancel methods?
URL: https://github.com/apache/arrow-adbc/issues/929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-adbc] lidavidm commented on issue #929: format: should we specify anything about signal-safety of the Cancel methods?
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #929:
URL: https://github.com/apache/arrow-adbc/issues/929#issuecomment-1648113529
IMO I don't think we can require AdbcConnectionCancel etc. to be signal-safe, practically, just looking at implementations (e.g. FlightSQL, not to mention, is making a Go FFI call signal-safe in the first place since Go swaps out the stack?). ([Postgres's is apparently safe, though!](https://www.postgresql.org/docs/current/libpq-cancel.html))
CC @zeroshade @pitrou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org