You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "mlbiscoc (via GitHub)" <gi...@apache.org> on 2026/10/19 20:18:26 UTC
[PR] SOLR-18544: Source CPU utilization metric from JFR instead JMX [solr]
mlbiscoc opened a new pull request, #5185:
URL: https://github.com/apache/solr/pull/5185
https://issues.apache.org/jira/browse/SOLR-18544
Partially a regression from [SOLR-18407](https://issues.apache.org/jira/browse/SOLR-18407) but also partially a JDK bug that got exposed from the OTEL upgrade.
What I found was running the `PlacementPluginIntegrationTest.testAttributeFetcherImpl` with `21.0.6-tem` fails but running with `21.0.9-tem` passes.
This was because previously the metric was sourced from JFR. Then after the upgrade it started to source it from JMX which exposed from JDK bug. So this change just sources it from JFR again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18544: Source CPU utilization metric from JFR instead JMX [solr]
Posted by "mlbiscoc (via GitHub)" <gi...@apache.org>.
mlbiscoc merged PR #5185:
URL: https://github.com/apache/solr/pull/5185
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18544: Source CPU utilization metric from JFR instead JMX [solr]
Posted by "nick-boss-tech (via GitHub)" <gi...@apache.org>.
nick-boss-tech commented on PR #5185:
URL: https://github.com/apache/solr/pull/5185#issuecomment-6389926992
**Quick Review:**
The JFR selector behaves as intended in the pinned OpenTelemetry version: it preserves the existing experimental metrics and suppresses the duplicate JMX CPU source.
P3 readiness issue: the changelog entry is missing, and the current-head validator fails for that reason. A short SOLR-18544 bug-fix entry should cover the operator-visible metric recovery.
Precommit and Crave tests are green. The older-JDK fix remains author-reported; the existing placement assertion checks metric presence, which alone does not prove that JFR samples update its value.
AI-generated static review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org