You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/09 16:14:46 UTC

[GitHub] [flink] XComp opened a new pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

XComp opened a new pull request #19028:
URL: https://github.com/apache/flink/pull/19028


   ## What is the purpose of the change
   
   The {{FileSystemJobResultStore}} does not close the {{OutputStream}} when writing the JobResult into the file. This PR fixes the issue.
   
   ## Brief change log
   
   * Adds try block around the {{OutputStream}} usage
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] XComp merged pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
XComp merged pull request #19028:
URL: https://github.com/apache/flink/pull/19028


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   * 13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   * 13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32775",
       "triggerID" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   * 13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32775) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   * 13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "CANCELED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1b4b5e91e821a8c048f1e2f4b485eb26fbd65180 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #19028: [FLINK-26555][runtime] Adds closing and flushing to OutputStream

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #19028:
URL: https://github.com/apache/flink/pull/19028#issuecomment-1063104634


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32767",
       "triggerID" : "1b4b5e91e821a8c048f1e2f4b485eb26fbd65180",
       "triggerType" : "PUSH"
     }, {
       "hash" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32775",
       "triggerID" : "13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 13d8d87b3a1066613b3c8ae7464d3a0a2e4a96eb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32775) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org