[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #43059: [SPARK-45281][CORE][TESTS] Update BenchmarkBase to use Java 17 as the base version

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #43059:
URL: https://github.com/apache/spark/pull/43059#discussion_r1334629527


##########
core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala:
##########
@@ -51,7 +51,7 @@ abstract class BenchmarkBase {
     val regenerateBenchmarkFiles: Boolean = System.getenv("SPARK_GENERATE_BENCHMARK_FILES") == "1"
     if (regenerateBenchmarkFiles) {
       val version = System.getProperty("java.version").split("\\D+")(0).toInt
-      val jdkString = if (version > 8) s"-jdk$version" else ""
+      val jdkString = if (version > 17) s"-jdk$version" else ""

Review Comment:
   We has been using `maven-enforcer-plugin` for the java version. We can assume Java 17+ dev environment.
   ```
                     <requireJavaVersion>
                       <version>${java.version}</version>
                     </requireJavaVersion>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org