You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2024/09/27 16:22:45 UTC
[PR] Improve tablet server batch reader iterator time tracking code [accumulo]
DomGarguilo opened a new pull request, #4927:
URL: https://github.com/apache/accumulo/pull/4927
This pull request introduces the `CountDownTimer` class to replace the existing `Timer` class for better handling of timeout and retry logic in the `TabletServerBatchReaderIterator` class. The most significant changes include the integration of `CountDownTimer` in various methods and the addition of new methods to the `CountDownTimer` class to support the new functionality.
### Integration of `CountDownTimer`:
* `TabletServerBatchReaderIterator.java`: Replaced `Timer` with `CountDownTimer` to simplify handling of retry timeouts and activity tracking in methods such as `doLookups`, `rebinToScanServers`, and `TimeoutTracker` class.
### Enhancements to `CountDownTimer` class:
* `CountDownTimer.java`: Added `restart` method to reset the timer and `timeLeft` method to get the remaining time as a `Duration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve tablet server batch reader iterator time tracking code [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #4927:
URL: https://github.com/apache/accumulo/pull/4927#issuecomment-3348302945
Things here should once again be up to date. I made a change to CountDownTimer internally to use a Timer so we are reusing this logic where possible.
Regarding previous discussion about whether to keep our CountDownTimer and Timer utilities, I think we should, as the other options are overkill for what we need or don't have the exact countdown functionality that we want here.
All tests are passing and I think this is ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve tablet server batch reader iterator time tracking code [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on PR #4927:
URL: https://github.com/apache/accumulo/pull/4927#issuecomment-2749304447
This branch is now up to date with main and ready for final review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve tablet server batch reader iterator time tracking code [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #4927:
URL: https://github.com/apache/accumulo/pull/4927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org