You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhengyuan-cn (via GitHub)" <gi...@apache.org> on 2023/03/06 05:32:52 UTC
[GitHub] [incubator-seatunnel] zhengyuan-cn opened a new pull request, #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
zhengyuan-cn opened a new pull request, #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283
[Bug] connector-influxdb dependency influxdb-java's version shuld be 2.15 not 2.21 #4230
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#discussion_r1198757386
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java:
##########
@@ -207,6 +207,38 @@ public void testInfluxdb(TestContainer container) throws IOException, Interrupte
}
}
}
+
+ @TestTemplate
+ public void testInfluxdbSqlTest(TestContainer container) throws IOException, InterruptedException {
+ Container.ExecResult execResult = container.executeJob("/influxdb-to-influxdb-sqltest.conf");
Review Comment:
@zhengyuan-cn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1473030740
Hi, can you help add this test case (SQL contains tz function) to InfluxDB E2E test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455797678
> I tested influxdb-java version 2.21-2.23 them not support, the Exception still .
Maybe we should update the code which SeaTunnel access InfluxDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455790631
> > hi, version 2.21 ,It's Happened NoSuchMethod when the dependency of influxdb-java's version 2.11 . downgraded version to 2.15 it works correct.
> > exception detail: 23/02/27 10:50:06 INFO AbstractPluginDiscovery: Load plugin: PluginIdentifier{engineType='seatunnel', pluginType='source', pluginName='InfluxDB'} from classpath Exception in thread "main" java.lang.NoSuchMethodError: kotlin.collections.ArraysKt.copyInto([B[BIII)[B at shaded.okio.Segment.writeTo(Segment.kt:169) at shaded.okio.Segment.compact(Segment.kt:152) at shaded.okio.Buffer.write(Buffer.kt:1842) at shaded.okio.Buffer.read(Buffer.kt:1854) at shaded.okio.Buffer.writeAll(Buffer.kt:1642) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:187) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:174) at shaded.okio.Options$Companion.buildTrieRecursive$default(Options.kt:113) at shaded.okio.Options$Companion.of(Options.kt:72) at shaded.okhttp3.internal.Util.(Util.kt:71) at shaded.okhttp3.internal.concurrent.TaskRunner.(TaskRunner.kt:309) at shaded.okhttp3.ConnectionPool.(ConnectionPool.kt:41) at shaded.okhttp3.ConnectionPool.(ConnectionPoo
l.kt:47) at shaded.okhttp3.OkHttpClient$Builder.(OkHttpClient.kt:471) at org.apache.seatunnel.connectors.seatunnel.influxdb.client.InfluxDBClient.getInfluxDB(InfluxDBClient.java:42) at org.apache.seatunnel.connectors.seatunnel.influxdb.source.InfluxDBSource.prepare(InfluxDBSource.java:84) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.initializePlugins(SourceExecuteProcessor.java:88) at org.apache.seatunnel.core.starter.spark.execution.AbstractPluginExecuteProcessor.(AbstractPluginExecuteProcessor.java:49) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.(SourceExecuteProcessor.java:51) at org.apache.seatunnel.core.starter.spark.execution.SparkExecution.(SparkExecution.java:50) at org.apache.seatunnel.core.starter.spark.command.SparkApiTaskExecuteCommand.execute(SparkApiTaskExecuteCommand.java:54) at org.apache.seatunnel.core.starter.Seatunnel.run(Seatunnel.java:39) at org.apache.seatunnel.core.starter.spark.SeatunnelSpark.main
(SeatunnelSpark.java:34) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52) at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:855) at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161) at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184) at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86) at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:930) at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:939) at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
>
> Are we use old api to access influxDB? Can we upgrade version and modify the way access influxDB?
I tested influxdb-java version 2.21-2.23 them not support, the Exception still .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455784907
> > hi, version 2.21 ,It's Happened NoSuchMethod when the dependency of influxdb-java's version 2.11 . downgraded version to 2.15 it works correct.
> > exception detail: 23/02/27 10:50:06 INFO AbstractPluginDiscovery: Load plugin: PluginIdentifier{engineType='seatunnel', pluginType='source', pluginName='InfluxDB'} from classpath Exception in thread "main" java.lang.NoSuchMethodError: kotlin.collections.ArraysKt.copyInto([B[BIII)[B at shaded.okio.Segment.writeTo(Segment.kt:169) at shaded.okio.Segment.compact(Segment.kt:152) at shaded.okio.Buffer.write(Buffer.kt:1842) at shaded.okio.Buffer.read(Buffer.kt:1854) at shaded.okio.Buffer.writeAll(Buffer.kt:1642) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:187) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:174) at shaded.okio.Options$Companion.buildTrieRecursive$default(Options.kt:113) at shaded.okio.Options$Companion.of(Options.kt:72) at shaded.okhttp3.internal.Util.(Util.kt:71) at shaded.okhttp3.internal.concurrent.TaskRunner.(TaskRunner.kt:309) at shaded.okhttp3.ConnectionPool.(ConnectionPool.kt:41) at shaded.okhttp3.ConnectionPool.(ConnectionPoo
l.kt:47) at shaded.okhttp3.OkHttpClient$Builder.(OkHttpClient.kt:471) at org.apache.seatunnel.connectors.seatunnel.influxdb.client.InfluxDBClient.getInfluxDB(InfluxDBClient.java:42) at org.apache.seatunnel.connectors.seatunnel.influxdb.source.InfluxDBSource.prepare(InfluxDBSource.java:84) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.initializePlugins(SourceExecuteProcessor.java:88) at org.apache.seatunnel.core.starter.spark.execution.AbstractPluginExecuteProcessor.(AbstractPluginExecuteProcessor.java:49) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.(SourceExecuteProcessor.java:51) at org.apache.seatunnel.core.starter.spark.execution.SparkExecution.(SparkExecution.java:50) at org.apache.seatunnel.core.starter.spark.command.SparkApiTaskExecuteCommand.execute(SparkApiTaskExecuteCommand.java:54) at org.apache.seatunnel.core.starter.Seatunnel.run(Seatunnel.java:39) at org.apache.seatunnel.core.starter.spark.SeatunnelSpark.main
(SeatunnelSpark.java:34) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52) at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:855) at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161) at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184) at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86) at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:930) at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:939) at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
>
> Are we use old api to access influxDB? Can we upgrade version and modify the way access influxDB?
I use influxDB version 1.8.10, seatunnel-influxDB use simple config. as below
`InfluxDB {
url="http://10.x.x.22:8086"
database="data_storage"
password="xxxxxx"
sql="select temp3,time from lunzi where time >= '2023-01-11 16:18:00' and time < '2023-01-11 16:19:00' tz('Asia/Shanghai')"
fields {
temp3 = float
time = bigint
}
result_table_name="source1"
}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455628952
Hi, why downgraded version？IMO, we should fix a bug by upgrade version or code, not downgraded version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#discussion_r1198757024
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java:
##########
@@ -207,6 +207,38 @@ public void testInfluxdb(TestContainer container) throws IOException, Interrupte
}
}
}
+
+ @TestTemplate
+ public void testInfluxdbSqlTest(TestContainer container) throws IOException, InterruptedException {
+ Container.ExecResult execResult = container.executeJob("/influxdb-to-influxdb-sqltest.conf");
Review Comment:
un commit this file？
influxdb-to-influxdb-sqltest.conf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhengyuan-cn closed pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn closed pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
URL: https://github.com/apache/seatunnel/pull/4283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/seatunnel/pull/4283#issuecomment-1605812131
recommited RP see: https://github.com/apache/seatunnel/pull/4829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 commented on pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1554363289
check ci error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1473033187
>
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455492259
[Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231
commit id: [1d1afc5] (https://github.com/apache/incubator-seatunnel/pull/4283/commits/1d1afc56407f093af3e6e45a4f435ac28c2ca4e5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1461144124
> > I tested influxdb-java version 2.21-2.23 them not support, the Exception still .
>
> Maybe we should update the code which SeaTunnel access InfluxDB.
hi, code in this commit, ,for bug #4231
[Bug] connector-influxdb module InfluxDBSource class's initColumnsIndex method, sql invalide when sql contains tz function cause by direct append QUERY_LIMIT #4231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#discussion_r1138003864
##########
seatunnel-connectors-v2/connector-influxdb/pom.xml:
##########
@@ -30,7 +30,7 @@
<name>SeaTunnel : Connectors V2 : Influxdb</name>
<properties>
- <influxdb.version>2.21</influxdb.version>
+ <influxdb.version>2.15</influxdb.version>
Review Comment:
Do not downgrade version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1469233245
Try merge from dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on a diff in pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on code in PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#discussion_r1138014926
##########
seatunnel-connectors-v2/connector-influxdb/pom.xml:
##########
@@ -30,7 +30,7 @@
<name>SeaTunnel : Connectors V2 : Influxdb</name>
<properties>
- <influxdb.version>2.21</influxdb.version>
+ <influxdb.version>2.15</influxdb.version>
Review Comment:
ok, let me recovery to 2.21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 closed pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 closed pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
URL: https://github.com/apache/incubator-seatunnel/pull/4283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455671633
> hi, version 2.21 ,It's Happened NoSuchMethod when the dependency of influxdb-java's version 2.11 . downgraded version to 2.15 it works correct.
>
> exception detail: 23/02/27 10:50:06 INFO AbstractPluginDiscovery: Load plugin: PluginIdentifier{engineType='seatunnel', pluginType='source', pluginName='InfluxDB'} from classpath Exception in thread "main" java.lang.NoSuchMethodError: kotlin.collections.ArraysKt.copyInto([B[BIII)[B at shaded.okio.Segment.writeTo(Segment.kt:169) at shaded.okio.Segment.compact(Segment.kt:152) at shaded.okio.Buffer.write(Buffer.kt:1842) at shaded.okio.Buffer.read(Buffer.kt:1854) at shaded.okio.Buffer.writeAll(Buffer.kt:1642) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:187) at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:174) at shaded.okio.Options$Companion.buildTrieRecursive$default(Options.kt:113) at shaded.okio.Options$Companion.of(Options.kt:72) at shaded.okhttp3.internal.Util.(Util.kt:71) at shaded.okhttp3.internal.concurrent.TaskRunner.(TaskRunner.kt:309) at shaded.okhttp3.ConnectionPool.(ConnectionPool.kt:41) at shaded.okhttp3.ConnectionPool.(ConnectionPool.
kt:47) at shaded.okhttp3.OkHttpClient$Builder.(OkHttpClient.kt:471) at org.apache.seatunnel.connectors.seatunnel.influxdb.client.InfluxDBClient.getInfluxDB(InfluxDBClient.java:42) at org.apache.seatunnel.connectors.seatunnel.influxdb.source.InfluxDBSource.prepare(InfluxDBSource.java:84) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.initializePlugins(SourceExecuteProcessor.java:88) at org.apache.seatunnel.core.starter.spark.execution.AbstractPluginExecuteProcessor.(AbstractPluginExecuteProcessor.java:49) at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.(SourceExecuteProcessor.java:51) at org.apache.seatunnel.core.starter.spark.execution.SparkExecution.(SparkExecution.java:50) at org.apache.seatunnel.core.starter.spark.command.SparkApiTaskExecuteCommand.execute(SparkApiTaskExecuteCommand.java:54) at org.apache.seatunnel.core.starter.Seatunnel.run(Seatunnel.java:39) at org.apache.seatunnel.core.starter.spark.SeatunnelSpark.main(S
eatunnelSpark.java:34) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52) at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:855) at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161) at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184) at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86) at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:930) at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:939) at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
Are we use old api to access influxDB? Can we upgrade version and modify the way access influxDB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1455656004
hi, version 2.21 ,It's Happened NoSuchMethod when the dependency of influxdb-java's version 2.11 .
downgraded version to 2.15 it works correct.
exception detail:
23/02/27 10:50:06 INFO AbstractPluginDiscovery: Load plugin: PluginIdentifier{engineType='seatunnel', pluginType='source', pluginName='InfluxDB'} from classpath
Exception in thread "main" java.lang.NoSuchMethodError: kotlin.collections.ArraysKt.copyInto([B[BIII)[B
at shaded.okio.Segment.writeTo(Segment.kt:169)
at shaded.okio.Segment.compact(Segment.kt:152)
at shaded.okio.Buffer.write(Buffer.kt:1842)
at shaded.okio.Buffer.read(Buffer.kt:1854)
at shaded.okio.Buffer.writeAll(Buffer.kt:1642)
at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:187)
at shaded.okio.Options$Companion.buildTrieRecursive(Options.kt:174)
at shaded.okio.Options$Companion.buildTrieRecursive$default(Options.kt:113)
at shaded.okio.Options$Companion.of(Options.kt:72)
at shaded.okhttp3.internal.Util.(Util.kt:71)
at shaded.okhttp3.internal.concurrent.TaskRunner.(TaskRunner.kt:309)
at shaded.okhttp3.ConnectionPool.(ConnectionPool.kt:41)
at shaded.okhttp3.ConnectionPool.(ConnectionPool.kt:47)
at shaded.okhttp3.OkHttpClient$Builder.(OkHttpClient.kt:471)
at org.apache.seatunnel.connectors.seatunnel.influxdb.client.InfluxDBClient.getInfluxDB(InfluxDBClient.java:42)
at org.apache.seatunnel.connectors.seatunnel.influxdb.source.InfluxDBSource.prepare(InfluxDBSource.java:84)
at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.initializePlugins(SourceExecuteProcessor.java:88)
at org.apache.seatunnel.core.starter.spark.execution.AbstractPluginExecuteProcessor.(AbstractPluginExecuteProcessor.java:49)
at org.apache.seatunnel.core.starter.spark.execution.SourceExecuteProcessor.(SourceExecuteProcessor.java:51)
at org.apache.seatunnel.core.starter.spark.execution.SparkExecution.(SparkExecution.java:50)
at org.apache.seatunnel.core.starter.spark.command.SparkApiTaskExecuteCommand.execute(SparkApiTaskExecuteCommand.java:54)
at org.apache.seatunnel.core.starter.Seatunnel.run(Seatunnel.java:39)
at org.apache.seatunnel.core.starter.spark.SeatunnelSpark.main(SeatunnelSpark.java:34)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:855)
at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:161)
at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:184)
at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:86)
at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:930)
at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:939)
at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhengyuan-cn commented on pull request #4283: [Bug] connector-influxdb dependency influxdb-java's version shuld be …
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on PR #4283:
URL: https://github.com/apache/incubator-seatunnel/pull/4283#issuecomment-1469217062
The failure check (Backend / unit-test (11, ubuntu-latest) need resolve? how can I resolve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [seatunnel] zhengyuan-cn commented on a diff in pull request #4283: [Bug] [Connector-V2] Fix InfluxDB SQL invalide when SQL contains tz function
Posted by "zhengyuan-cn (via GitHub)" <gi...@apache.org>.
zhengyuan-cn commented on code in PR #4283:
URL: https://github.com/apache/seatunnel/pull/4283#discussion_r1201358527
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java:
##########
@@ -207,6 +207,38 @@ public void testInfluxdb(TestContainer container) throws IOException, Interrupte
}
}
}
+
+ @TestTemplate
+ public void testInfluxdbSqlTest(TestContainer container) throws IOException, InterruptedException {
+ Container.ExecResult execResult = container.executeJob("/influxdb-to-influxdb-sqltest.conf");
Review Comment:
sorry I forgot commit it,
Now, commited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org