You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/07/01 01:49:52 UTC

[GitHub] [apisix] tzssangglass commented on a diff in pull request #7355: feat: add hostname config

tzssangglass commented on code in PR #7355:
URL: https://github.com/apache/apisix/pull/7355#discussion_r911555398


##########
apisix/core/utils.lua:
##########
@@ -253,6 +253,13 @@ function _M.gethostname()
         return hostname
     end
 
+    local local_conf = config_local.local_conf()

Review Comment:
   In some runtime scenarios, the hostname is not known before startup, but only at runtime, and the hostname cannot be configured before startup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org