[GitHub] [druid] cheddar commented on a change in pull request #12048: fix IncrementalIndex performance regression

[GitBox <gi...@apache.org>]

cheddar commented on a change in pull request #12048:
URL: https://github.com/apache/druid/pull/12048#discussion_r766220636



##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -441,6 +441,19 @@ public InputRow formatRow(InputRow row)
     return builder.build();
   }
 
+  @Nullable
+  @Override
+  public ColumnCapabilities getColumnCapabilities(String columnName)
+  {
+    if (timeAndMetricsColumnCapabilities.containsKey(columnName)) {
+      return timeAndMetricsColumnCapabilities.get(columnName);
+    }
+    if (dimensionDescs.containsKey(columnName)) {

Review comment:
       Looking through the code in IncrementalIndex, sometimes `dimensionDescs` is accessed with synchronization.  Sometimes it is not.  Assuming that it's okay to access it without synchronization, this looks good.  Have we verified that we will already be in a synchronized block once we get to this method?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org