[GitHub] mistercrunch commented on a change in pull request #4604: Show "Range Filter" by default

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4604: Show "Range Filter" by default
URL: https://github.com/apache/incubator-superset/pull/4604#discussion_r174345221
 
 

 ##########
 File path: superset/assets/visualizations/nvd3_vis.js
 ##########
 @@ -158,9 +159,10 @@ function nvd3Vis(slice, payload) {
     if (svg.empty()) {
       svg = d3.select(slice.selector).append('svg');
     }
+    let height = slice.height();
     switch (vizType) {
       case 'line':
-        if (fd.show_brush) {
+        if (fd.show_brush === 'yes' || (fd.show_brush === 'auto' && height > minHeightForBrush)) {
 
 Review comment:
   We should probably also still handle `true` for the existing saved slices

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services