You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by jotomo <gi...@git.apache.org> on 2014/10/13 22:06:36 UTC
[GitHub] tika pull request: Rome 1.5 retry
GitHub user jotomo opened a pull request:
https://github.com/apache/tika/pull/19
Rome 1.5 retry
Well, after repeatedly shooting myself in the food by trying to run the tests with Java 8 (yields a NoClassDefFound: org.slf4j.LoggerFactory error. Fancy), I seem to have fixed this.
The dependency from _netcdf_ to _jdom_, which was is declared optional in _netcdf_'s POM was (inadvertendly) satifisfied by _rome_, until _rome_ upgraded to _jdom2_ with the upgrade to _rome_ 1.5. This fix makes _netcdf_'s dependency on _jdom_ (1), which apparently is not optional, explicit and required. Resulting in all tests being green again. I chose this approach over the more aggressive one where _netcdf_ is updated, which would then require the same version of _jdom_ as _rome_ (and then also declares that dependency as non-optional), however I can't predict the impact that upgrade would have. Furthermore, that upgrade adds dependencies to libs not available on sonatype/maven.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jotomo/tika rome-1.5-retry
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tika/pull/19.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19
----
commit 32aadd083759b9022d152869f8f2990e5359bb8c
Author: Johannes Mockenhaupt <gi...@jotomo.de>
Date: 2014-10-06T12:58:54Z
Revert "Revert TIKA-1435 until we figure out the Rome/JDOM/HDFParser issue merge 1629338:1629337"
This reverts commit be824cc499eee3e975003ecc3a7ae1e91d86c195.
commit fb9df6d51aeee2fc8ee7e2877cf974c8f266457b
Author: Johannes Mockenhaupt <gi...@jotomo.de>
Date: 2014-10-06T15:30:18Z
Make netcdf's dependency on jdom explicit (netcdf declares it with scope provided).
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tika pull request: Rome 1.5 retry
Posted by jotomo <gi...@git.apache.org>.
Github user jotomo closed the pull request at:
https://github.com/apache/tika/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---