Re: svn commit: r157948 - in httpd/httpd/trunk/srclib/pcre: pcre.c study.c

[Joe Orton <jo...@redhat.com>]

On Thu, Mar 17, 2005 at 05:50:31PM -0000, William Rowe wrote:
> Author: wrowe
> Date: Thu Mar 17 09:50:29 2005
> New Revision: 157948
> 
> URL: http://svn.apache.org/viewcvs?view=rev&rev=157948
> Log:
> 
>   Fix three problems with pcre for portability;
> 
>   1. study.c's pointer arg didn't jive with pcre_fullinfo()'s prototype,
>      however there was no (trivial) way to get them to concur.  Cast in
>      this case was the least of several evils.

I don't see why this is needed - the last argument to pcre_fullinfo() is
void * already, so the cast is surely unnecessary?

>   2. byteflip had an error for high-bit set bytes, because right shift
>      signed is allowed to extend the sign bit.  These had to be unsigned,
>      and the real_pcre types were the safest way to do this.
> 
>   3. split byteflip into byteflip2/4, to drop size truncation emits, 
>      as the arguments are unambigiously 16 or 32 bits as defined 
>      in pcre_internal.h.

Did you send these upstream to Phil Hazel? <ph10 cam.ac.uk>

Regards,

joe