You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/06/07 12:19:03 UTC

[GitHub] [drill] cgivre commented on a diff in pull request #2568: DRILL-8242: Fix output for HttpHelperFunctions

cgivre commented on code in PR #2568:
URL: https://github.com/apache/drill/pull/2568#discussion_r891145801


##########
contrib/storage-http/src/main/java/org/apache/drill/exec/store/http/udfs/HttpHelperFunctions.java:
##########
@@ -75,9 +75,6 @@ public void eval() {
       // as an approximation of null-if-null handling.
       if (args == null) {
         // Return empty map
-        org.apache.drill.exec.vector.complex.writer.BaseWriter.MapWriter mapWriter = writer.rootAsMap();
-        mapWriter.start();

Review Comment:
   Do we still need the `writer` object in this class?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org