You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2024/03/20 06:55:24 UTC
[PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
huangxiaopingRD opened a new pull request, #45605:
URL: https://github.com/apache/spark/pull/45605
### What changes were proposed in this pull request?
Add paths information to the error log
### Why are the changes needed?
Make it easier for users to troubleshoot problems
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #45605:
URL: https://github.com/apache/spark/pull/45605#issuecomment-2014389048
+1, LGTM. Merging to master.
Thank you, @huangxiaopingRD and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #45605:
URL: https://github.com/apache/spark/pull/45605#discussion_r1533394588
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -5271,7 +5271,7 @@
},
"_LEGACY_ERROR_TEMP_1148" : {
"message" : [
- "Can only write data to relations with a single path."
+ "Can only write data to relations with a single path, paths are <paths>"
Review Comment:
```suggestion
"Can only write data to relations with a single path but given paths are <paths>"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #45605:
URL: https://github.com/apache/spark/pull/45605#discussion_r1533409963
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -5271,7 +5271,7 @@
},
"_LEGACY_ERROR_TEMP_1148" : {
Review Comment:
Okay, I'll update it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45605:
URL: https://github.com/apache/spark/pull/45605#discussion_r1533407408
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -5271,7 +5271,7 @@
},
"_LEGACY_ERROR_TEMP_1148" : {
Review Comment:
Could you add a sub-class to `UNSUPPORTED_INSERT` with a name like `MULTI_PATH`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk closed pull request #45605: [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log
URL: https://github.com/apache/spark/pull/45605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #45605:
URL: https://github.com/apache/spark/pull/45605#discussion_r1533408574
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -5271,7 +5271,7 @@
},
"_LEGACY_ERROR_TEMP_1148" : {
"message" : [
- "Can only write data to relations with a single path."
+ "Can only write data to relations with a single path, paths are <paths>"
Review Comment:
Done. Thanks for your review. @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47479][SQL] Optimize cannot write data to relations with multiple paths error log [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on code in PR #45605:
URL: https://github.com/apache/spark/pull/45605#discussion_r1533407408
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -5271,7 +5271,7 @@
},
"_LEGACY_ERROR_TEMP_1148" : {
Review Comment:
Could you add a sub-class to `UNSUPPORTED_INSERT` with a name like `MULTI_PATH` or something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org