You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by ghenry22 <gi...@git.apache.org> on 2015/07/08 09:01:23 UTC

[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

GitHub user ghenry22 opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/125

    CB-9331 cordova-plugin-file

    resolves CB-9331, correct the value queried on iOS devices so that free getFreeDiskSpace() returns a valid value instead of always returning 0.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ghenry22/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/125.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #125
    
----
commit 655ab124586a0431e21431f28ba02db1718fdeb3
Author: ghenry22 <gh...@gmail.com>
Date:   2015-07-07T10:29:28Z

    CB-6703cordova-plugin-file
    
    Fix getFreeSpace always returns 0 on iOS

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

Posted by ghenry22 <gi...@git.apache.org>.
Github user ghenry22 commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119771695
  
    Hi edades,
    
    I don't think that is relevant to this pull request, I have this plugin (with and without this pull request) in my project and it works fine.
    
    Please make sure that you are testing on a physical device, it looks like maybe you are testing on Chrome?  Deviceready will not fire if you are not using a physical device (or an appropriate emulator).  In your screenshot I see device ready has not fired which seems to confirm this.  Anyway I would suggest searching around a bit as you won't be likely to get much response to a post here as the question doesn't relate to this pull request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

Posted by edades <gi...@git.apache.org>.
Github user edades commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/125#issuecomment-119638131
  
    Hi, sorry for write here.
    I have a problem with this plugin, this interrupt the load of cordova.js, and my page refresh all the time.
    And this problem is only when i install this plugin.
    
    Check the screenshots.
    
    Thanks :)
    
    ![captura de pantalla 2015-07-08 a las 12 04 29](https://cloud.githubusercontent.com/assets/401513/8575367/04297278-2572-11e5-8669-fc81a953c4e8.png)
    ![captura de pantalla 2015-07-08 a las 12 04 45](https://cloud.githubusercontent.com/assets/401513/8575368/04478d62-2572-11e5-9639-4919b32cd8a8.png)
    ![captura de pantalla 2015-07-08 a las 12 07 31](https://cloud.githubusercontent.com/assets/401513/8575434/55ed8554-2572-11e5-8e96-441090902710.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-plugin-file pull request: CB-9331 cordova-plugin-file

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-plugin-file/pull/125


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org