[GitHub] [incubator-doris] morningman commented on a change in pull request #7180: [Bug] fix insert load should have the same behavior as stream load

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #7180:
URL: https://github.com/apache/incubator-doris/pull/7180#discussion_r755031800



##########
File path: fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java
##########
@@ -1238,6 +1238,13 @@ private void handleInsertStmt() throws Exception {
                     }
                 }
 
+                if (filteredRows > 0 &&
+                        (1 / (1 + (double) loadedRows / filteredRows)) > Config.default_max_filter_ratio) {

Review comment:
       I didn't even know that we have this config....
   And I find that it only be used in the old load job, which is deprecated...
   
   So I think better not use it. May be we can add a new session variable for insert operation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org