You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:31:44 UTC

[GitHub] [ozone] avijayanhwx opened a new pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

avijayanhwx opened a new pull request #1773:
URL: https://github.com/apache/ozone/pull/1773


   ## What changes were proposed in this pull request?
   Cleanup of OM and HDDS layout version manager classes. Moved away from static initialization for ease of unit testing. 
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-4219
   
   ## How was this patch tested?
   Unit testing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1773:
URL: https://github.com/apache/ozone/pull/1773#issuecomment-760347708


   Thanks for the review @fapifta  & @swagle!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1773:
URL: https://github.com/apache/ozone/pull/1773#issuecomment-760305829


   Failed test in CI (TestSCMRestart) was fixed in HDDS-4679. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] fapifta commented on pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

Posted by GitBox <gi...@apache.org>.
fapifta commented on pull request #1773:
URL: https://github.com/apache/ozone/pull/1773#issuecomment-758308116


   Hi @avijayanhwx thank you for working on this one, the changes look good to me.
   
   One thing I would note is the missing newline at the end of the HDDSLayoutFeature class, other than that it looks good to me.
   +1 otherwise.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx commented on pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on pull request #1773:
URL: https://github.com/apache/ozone/pull/1773#issuecomment-758377090


   > Hi @avijayanhwx thank you for working on this one, the changes look good to me.
   > 
   > One thing I would note is the missing newline at the end of the HDDSLayoutFeature class, other than that it looks good to me.
   > +1 otherwise.
   
   Thanks for the review @fapifta. Based on offline review, I have further simplified the HDDS actions. PTAL 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] avijayanhwx merged pull request #1773: HDDS-4219. Revisit 'static' nature of OM Layout Version Manager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #1773:
URL: https://github.com/apache/ozone/pull/1773


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org