You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/27 23:03:37 UTC
[GitHub] [arrow] zeroshade opened a new pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
zeroshade opened a new pull request #11566:
URL: https://github.com/apache/arrow/pull/11566
When a major version update goes out, the Go import path and module name should update accordingly with a `/v<majorversion>` suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738730835
##########
File path: go/parquet/writer_properties.go
##########
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comment:
Umm...
How about the following approach?
1. master doesn't use `/vX` suffix.
2. We add `/vX` suffix including `github.com/apache/arrow/go/arrow/` in `go/parquet/`.
3. We create `go/arrow/vX.Y.Z` and `go/parquet/vX.Y.Z` tags in https://cwiki.apache.org/confluence/display/ARROW/Release+Management+Guide#ReleaseManagementGuide-Sourcereleaseandvote phase (just after `git push -u apache apache-arrow-<version>`) not `dev/release/post-13-go.sh` phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954164579
@kou that said, if the 6.0.1 release points the updated `release-6.0.0` branch which will have the updated `go.mod` files, then we can just ignore the `v6.0.0` tags and remove them, starting the versioning with v6.0.1 which would work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738752305
##########
File path: go/parquet/writer_properties.go
##########
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comment:
if we are going to keep the arrow and parquet modules versioned separately with their own go.mod files, then what would need to happen would be:
1. Create `go/arrow/vX.Y.Z` tag pointing at commit which contains `/vX` in the arrow directory and its files. push it to github
2. add `/vX` suffix to `github.com/apache/arrow/go/arrow/` import statements throughout the .go files of `go/parquet/` and run `go get -u github.com/apache/arrow/go/arrow@vX.Y.Z` so it updates the go.mod and the go.sum files.
3. commit the modified .go files in the `parquet/` dirs and the modified `go.mod` and `go.sum` to git
4. Create `go/parquet/vX.Y.Z` tag pointing at this new commit.
The only way to avoid the extra commit is if we lift the `go.mod` file up one directory to make the modules get versioned together as separate packages of a single module rather than two separate modules. Then we'd only need one tag of `go/vX.Y.Z` for both arrow and parquet libraries, and users would import using `github.com/apache/arrow/go/v6/arrow` instead of `github.com/apache/arrow/go/arrow/v6`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-964338658
bump @kou can you just take a sanity check here please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954152637
> (will that also update the go/arrow/v6 tag and go/parquet/v6 tag? or will that need to be done manually afterwards?)
Do these tags mean https://github.com/apache/arrow/tree/go/arrow%2Fv6.0.1 and https://github.com/apache/arrow/tree/go/parquet%2Fv6.0.1 ? (They don't exist yet because we don't release 6.0.1 yet.)
Or should we create new https://github.com/apache/arrow/tree/go/arrow%2Fv6 and https://github.com/apache/arrow/tree/go/parquet%2Fv6 tags ?
If they mean https://github.com/apache/arrow/tree/go/arrow%2Fv6.0.1 and https://github.com/apache/arrow/tree/go/parquet%2Fv6.0.1 , they will be created by `dev/release/post-13-go.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-953897653
@kou i've added the initial update of the .go files etc. and the go.mod files, they won't need any change for a v6.0.1 release, but will get changed for the development branch update to v7 since the `/v#` piece should always correspond to the major version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-962173368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954156625
@kou i've created https://github.com/apache/arrow/pull/11570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-965748593
I'll update test code written in Ruby after I 6.0.1 RC1. Please wait for a while...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-968365304
Benchmark runs are scheduled for baseline = bc219186db40ec6966eab91ee2dec24b2ebcfca1 and contender = 5bacdeaf290e833948e002e529a7ef070c8577e6. 5bacdeaf290e833948e002e529a7ef070c8577e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bf076cb55b2d4d278e9a1ce0066cfbee...457afde87d0b47f69ecaaa38a50868c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7dc6afbefead4aef972d424f0692db4d...215c8c7de4944ac092ff0b7374c87406/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/50dfdcdec9ea44b09533db4b9d0a2005...0cc744a2c7344de983a2f26fa3d808e0/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-968365304
Benchmark runs are scheduled for baseline = bc219186db40ec6966eab91ee2dec24b2ebcfca1 and contender = 5bacdeaf290e833948e002e529a7ef070c8577e6. 5bacdeaf290e833948e002e529a7ef070c8577e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bf076cb55b2d4d278e9a1ce0066cfbee...457afde87d0b47f69ecaaa38a50868c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7dc6afbefead4aef972d424f0692db4d...215c8c7de4944ac092ff0b7374c87406/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/50dfdcdec9ea44b09533db4b9d0a2005...0cc744a2c7344de983a2f26fa3d808e0/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou edited a comment on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou edited a comment on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-965748593
I'll update test code written in Ruby after 6.0.1 RC1. Please wait for a while...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-968365304
Benchmark runs are scheduled for baseline = bc219186db40ec6966eab91ee2dec24b2ebcfca1 and contender = 5bacdeaf290e833948e002e529a7ef070c8577e6. 5bacdeaf290e833948e002e529a7ef070c8577e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bf076cb55b2d4d278e9a1ce0066cfbee...457afde87d0b47f69ecaaa38a50868c8/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7dc6afbefead4aef972d424f0692db4d...215c8c7de4944ac092ff0b7374c87406/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/50dfdcdec9ea44b09533db4b9d0a2005...0cc744a2c7344de983a2f26fa3d808e0/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954148087
@kou That would be correct i believe and sounds good to me. I'll make the JIRA card for that PR against release-6.0.0 (will that also update the go/arrow/v6 tag and go/parquet/v6 tag? or will that need to be done manually afterwards?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-953372494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954146869
Can I clarify this? Are the followings right?
* v6.0.1 needs `/v6` suffix
* We should automate `/vX` suffix update on release.
* master should use `/v7` suffix.
If they are right, how about the following?
1. Create a pull request against the `release-6.0.0` branch that only adds `/v6` suffix. It doesn't have `dev/release/utils-prepare.sh` changes. This also needs a new Jira issue.
2. This pull request uses `/v7` suffix not `/v6` suffix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a change in pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738693412
##########
File path: go/parquet/writer_properties.go
##########
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comment:
Do we need to update this too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-966489888
Sounds good, Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-968365304
Benchmark runs are scheduled for baseline = bc219186db40ec6966eab91ee2dec24b2ebcfca1 and contender = 5bacdeaf290e833948e002e529a7ef070c8577e6. 5bacdeaf290e833948e002e529a7ef070c8577e6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/bf076cb55b2d4d278e9a1ce0066cfbee...457afde87d0b47f69ecaaa38a50868c8/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7dc6afbefead4aef972d424f0692db4d...215c8c7de4944ac092ff0b7374c87406/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/50dfdcdec9ea44b09533db4b9d0a2005...0cc744a2c7344de983a2f26fa3d808e0/)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-953434911
Could you also update all `.go` files in this pull request?
Then we can update tests for `01-prepare.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-954155027
https://github.com/apache/arrow/tree/go/arrow%2Fv6 and https://github.com/apache/arrow/tree/go/parquet%2Fv6 will need to point to a commit which will contain the updated go.mod that has the v6. I dont remember offhand whether or not having the tag point to the release-6.0.0 branch will mean the tag is updated when we merge into that branch or not. If merging the fix with the `/v6` suffix into `release-6.0.0` is sufficient that those tags point to the "new" head of `release-6.0.0` then we're good. Otherwise we'd need to remake those tags
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a change in pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on a change in pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#discussion_r738703107
##########
File path: go/parquet/writer_properties.go
##########
@@ -18,7 +18,7 @@ package parquet
import (
"github.com/apache/arrow/go/arrow/memory"
Review comment:
so that's where things get a bit more complex and i'm still trying to figure out the best way to go about it.
Technically it should get updated to point at the v6, but we can't do that correctly (and update the go.sum) until the arrow change is done and there is a tag go/arrow/v6.0.# etc. which points to a branch where go/arrow/go.mod has the v6. After the tag exists pointing at the v6, we can then update the parquet dependency on Arrow via `go get`. Basically, we'd need the arrow and parquet tags to point at different commits so that the arrow tag would already exist when we update the parquet version tag.
All this is because the arrow and parquet directories specify separate individual modules and have their own go.mods. The alternative would be to shift the go.mod up one directory and making the arrow and parquet modules just two packages of the same module which would have us versioning them together instead of versioning them separately (which is potentially desireable). Any drawback would only exist in development in that anyone who wanted to only depend on arrow would *also* depend on the parquet lib too from a dependency standpoint, even if the files wouldn't get included when compiling a project that didn't use the parquet library at all.
so, what're your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
kou closed pull request #11566:
URL: https://github.com/apache/arrow/pull/11566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade commented on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-953977332
@kou this is interesting, so this change would bump everything to v6 correctly which is needed to properly do the 6.0.1 release. but the tests in 01-prepare-test.rb are looking for the bumped "development version" so expect the diffs produced to be going from `v7` to `v8`. So how should i handled updating the tests here and the bump to v7 in the files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade edited a comment on pull request #11566: ARROW-14493: [Release][Go] Add update of import path for major versions to script
Posted by GitBox <gi...@apache.org>.
zeroshade edited a comment on pull request #11566:
URL: https://github.com/apache/arrow/pull/11566#issuecomment-953897653
@kou i've added the initial update of the .go files etc. and the go.mod files, they won't need any change for a v6.0.1 release, but will get changed for the development branch update to v7 since the `/v#` piece should always correspond to the major version. Do you want me to try to figure out how to update the utils-prepare tests for this? I can take a stab at it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org