You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/15 05:52:43 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #3551: esp32: module related fixes

yamt opened a new pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551


   ## Summary
   Fix a few issues I noticed when testing today's master.
   
   ## Impact
   esp32 CONFIG_MODULE
   
   ## Testing
   tested on a devkit-c board.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820216413


   > i guess i need to drop CONFIG_ESP32_QEMU_IMAGE from configs to pass the gate.
   
   Where the checks failing with CONFIG_ESP32_QEMU_IMAGE?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820156336


   i guess i need to drop CONFIG_ESP32_QEMU_IMAGE from configs to pass the gate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820277188


   > i just assumed that the CI was not providing ESPTOOL_BINDIR and haven't investigated further.
   
   Ah, yes, that should be the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 merged pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820245494


   > > i guess i need to drop CONFIG_ESP32_QEMU_IMAGE from configs to pass the gate.
   > 
   > Were the checks failing with CONFIG_ESP32_QEMU_IMAGE?
   
   configs with CONFIG_ESP32_QEMU_IMAGE was failing to build.
   i just assumed that the CI was not providing ESPTOOL_BINDIR and haven't investigated further.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 edited a comment on pull request #3551: esp32: module related fixes

Posted by GitBox <gi...@apache.org>.
Ouss4 edited a comment on pull request #3551:
URL: https://github.com/apache/incubator-nuttx/pull/3551#issuecomment-820216413


   > i guess i need to drop CONFIG_ESP32_QEMU_IMAGE from configs to pass the gate.
   
   Were the checks failing with CONFIG_ESP32_QEMU_IMAGE?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org