You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ozone.apache.org by si...@apache.org on 2022/12/16 21:22:49 UTC

[ozone] branch HDDS-6517-Snapshot updated: HDDS-7647. [snapshot] Add unit-testcases for Ozone Snapshot List API (#4090)

This is an automated email from the ASF dual-hosted git repository.

siyao pushed a commit to branch HDDS-6517-Snapshot
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/HDDS-6517-Snapshot by this push:
     new 7f8838070e HDDS-7647. [snapshot] Add unit-testcases for Ozone Snapshot List API (#4090)
7f8838070e is described below

commit 7f8838070e0af202b85cacf9a88cc6b64e1f9497
Author: jyotirmoy-gh <69...@users.noreply.github.com>
AuthorDate: Sat Dec 17 02:52:41 2022 +0530

    HDDS-7647. [snapshot] Add unit-testcases for Ozone Snapshot List API (#4090)
---
 .../hadoop/ozone/om/TestOmMetadataManager.java     | 38 ++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java
index 84dc514649..4bd57071b8 100644
--- a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java
+++ b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java
@@ -732,4 +732,42 @@ public class TestOmMetadataManager {
         arguments("vol1", "nonexistentBucket", BUCKET_NOT_FOUND)
     );
   }
+
+  @Test
+  public void testListSnapshotDoesNotListOtherBucketSnapshots() throws Exception {
+    String vol1 = "vol1";
+    String bucket1 = "bucket1";
+    String bucket2 = "bucket2";
+
+    OMRequestTestUtils.addVolumeToDB(vol1, omMetadataManager);
+    addBucketsToCache(vol1, bucket1);
+    addBucketsToCache(vol1, bucket2);
+    String snapshotName1 = "snapshot1-";
+    String snapshotName2 = "snapshot2-";
+
+    for (int i = 1; i <= 2; i++) {
+      OMRequestTestUtils.addSnapshotToTable(vol1, bucket1,
+              snapshotName1 + i, omMetadataManager);
+    }
+
+    for (int i = 1; i <= 5; i++) {
+      OMRequestTestUtils.addSnapshotToTable(vol1, bucket2,
+              snapshotName2 + i, omMetadataManager);
+    }
+
+    //Test listing snapshots only lists snapshots of specified bucket
+    List<SnapshotInfo> snapshotInfos1 = omMetadataManager.listSnapshot(vol1,
+            bucket1);
+    assertEquals(2, snapshotInfos1.size());
+    for (SnapshotInfo snapshotInfo : snapshotInfos1) {
+      assertTrue(snapshotInfo.getName().startsWith(snapshotName1));
+    }
+
+    List<SnapshotInfo> snapshotInfos2 = omMetadataManager.listSnapshot(vol1,
+            bucket2);
+    assertEquals(5, snapshotInfos2.size());
+    for (SnapshotInfo snapshotInfo : snapshotInfos2) {
+      assertTrue(snapshotInfo.getName().startsWith(snapshotName2));
+    }
+  }
 }
\ No newline at end of file


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ozone.apache.org
For additional commands, e-mail: commits-help@ozone.apache.org