You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2015/07/06 07:19:55 UTC
[GitHub] storm pull request: STORM-926:change pom to use maven-shade-plugin...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/621
STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar and fix duplicated classes warnings of flue-examples
1: fix external/flux/flux-examples duplicated classes warings
```
[WARNING] commons-collections-3.2.1.jar, commons-beanutils-core-1.8.0.jar, commons-beanutils-1.7.0.jar define 3 overlappping classes:
[WARNING] - org.apache.commons.collections.ArrayStack
[WARNING] - org.apache.commons.collections.BufferUnderflowException
[WARNING] - org.apache.commons.collections.Buffer
[WARNING] javax.servlet-3.1.jar, servlet-api-2.5-6.1.14.jar, javax.servlet-api-3.0.1.jar, servlet-api-2.5.jar define 17 overlappping classes:
[WARNING] - javax.servlet.ServletInputStream
[WARNING] - javax.servlet.Filter
[WARNING] - javax.servlet.http.HttpSession
[WARNING] - javax.servlet.FilterConfig
[WARNING] - javax.servlet.FilterChain
[WARNING] - javax.servlet.http.Cookie
[WARNING] - javax.servlet.http.HttpServletResponse
[WARNING] - javax.servlet.ServletConfig
[WARNING] - javax.servlet.RequestDispatcher
[WARNING] - javax.servlet.ServletRequest
[WARNING] - 7 more...
[WARNING] javax.servlet-3.1.jar, javax.servlet-api-3.0.1.jar define 26 overlappping classes:
[WARNING] - javax.servlet.Registration
[WARNING] - javax.servlet.DispatcherType
[WARNING] - javax.servlet.ServletRegistration$Dynamic
[WARNING] - javax.servlet.FilterRegistration
[WARNING] - javax.servlet.Registration$Dynamic
[WARNING] - javax.servlet.annotation.ServletSecurity$TransportGuarantee
[WARNING] - javax.servlet.FilterRegistration$Dynamic
[WARNING] - javax.servlet.descriptor.JspPropertyGroupDescriptor
[WARNING] - javax.servlet.annotation.ServletSecurity$EmptyRoleSemantic
[WARNING] - javax.servlet.descriptor.TaglibDescriptor
[WARNING] - 16 more...
[WARNING] hadoop-yarn-api-2.2.0.jar, hadoop-yarn-common-2.2.0.jar define 1 overlappping classes:
[WARNING] - org.apache.hadoop.yarn.util.package-info
[WARNING] maven-shade-plugin has detected that some .class files
[WARNING] are present in two or more JARs. When this happens, only
[WARNING] one single version of the class is copied in the uberjar.
[WARNING] Usually this is not harmful and you can skeep these
[WARNING] warnings, otherwise try to manually exclude artifacts
[WARNING] based on mvn dependency:tree -Ddetail=true and the above
[WARNING] output
```
2. minimized shade jars
For example:
mini flux-examples-0.11.0-SNAPSHOT.jar size from 52M to 12M
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-926
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/621.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #621
----
commit 18ca7966583902e2895949e01c8ea07457c44cb5
Author: caofangkun <ca...@gmail.com>
Date: 2015-07-06T05:14:18Z
STORM-926:change pom to use maven-shade-plugin:2.2 and minimize the size of shade jar and fix duplicated classes warnings of flue-examples
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-926:change pom to use maven-shade-plugin...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/621#issuecomment-122013414
The changes look fine to me. I am a bit concerned about minimizing the shaded jars. Have you tested this in a stand alone cluster? My understanding is that it removes classes that don't appear to be included from the original code, and with clojure I'm not 100% confident that everything is showing up properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-926:change pom to use maven-shade-plugin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-926:change pom to use maven-shade-plugin...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/621#issuecomment-122027544
I ran my own cluster and it looks good so I am inclined to check it in +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---