You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2016/12/06 06:54:25 UTC
[kudu-CR] Output more info when a snapshot scan fails due to history gc
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5374
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Output more info when a snapshot scan fails due to history gc
This just adds some niceties to the error message, like
both timestamps and the physical time difference between
them.
Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 9 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/5374/1
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5374/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
PS2, Line 1538: Timestamp ancient_history_mark;
> nit: consider removing this since it's not needed.
Done
PS2, Line 1548:
> nit: consider adding comma/semicolon or other
Done
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/5374/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
PS2, Line 1538: Timestamp ancient_history_mark;
nit: consider removing this since it's not needed.
PS2, Line 1548:
nit: consider adding comma/semicolon or other
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5374
to look at the new patch set (#4).
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Output more info when a snapshot scan fails due to history gc
This just adds some niceties to the error message, like
both timestamps and the physical time difference between
them.
Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/5374/4
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged.
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Output more info when a snapshot scan fails due to history gc
This just adds some niceties to the error message, like
both timestamps and the physical time difference between
them.
Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Reviewed-on: http://gerrit.cloudera.org:8080/5374
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/tserver/tablet_service.cc
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
Mike Percy: Looks good to me, approved
Todd Lipcon: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Output more info when a snapshot scan fails due to history gc
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Output more info when a snapshot scan fails due to history gc
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5374
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id488fd0366a8e8c5c2a21289a835207ea795ad20
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No