You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/04/29 15:36:12 UTC
[GitHub] [incubator-kvrocks] tisonkun opened a new pull request, #548: Apply Apache License header for Tcl files
tisonkun opened a new pull request, #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548
This closes #547.
Signed-off-by: tison <wa...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#issuecomment-1113915330
@Hexiaoqiao in the last turn #542 I've checked all other files except these tcl files. And this turn I dealt with them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#issuecomment-1113489082
Hold as most tcl files are copied and modified from Redis files. We should take care of BSD-3 Clause License requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] vongosling commented on a diff in pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
vongosling commented on code in PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#discussion_r862418962
##########
licenses/LICENSE.redis:
##########
@@ -0,0 +1,10 @@
+Copyright (c) 2006-2020, Salvatore Sanfilippo
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
Review Comment:
We should care about the redistribution requirements here. Do we check the compatibility with ASL v2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] git-hulk commented on pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#issuecomment-1113460893
cc @ShooterIT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] Hexiaoqiao commented on pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
Hexiaoqiao commented on PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#issuecomment-1113921108
Thanks. +1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun merged pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#issuecomment-1113456427
cc @Hexiaoqiao @git-hulk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#discussion_r862420402
##########
licenses/LICENSE.redis:
##########
@@ -0,0 +1,10 @@
+Copyright (c) 2006-2020, Salvatore Sanfilippo
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
Review Comment:
> ASL v2
Do you mean Apache License 2.0?
> compatibility
This is a typical 3-Clause BSD License which is compatible with Apache License 2.0.
* https://www.apache.org/legal/resolved.html#category-a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] vongosling commented on a diff in pull request #548: Apply Apache License header for Tcl files
Posted by GitBox <gi...@apache.org>.
vongosling commented on code in PR #548:
URL: https://github.com/apache/incubator-kvrocks/pull/548#discussion_r862418962
##########
licenses/LICENSE.redis:
##########
@@ -0,0 +1,10 @@
+Copyright (c) 2006-2020, Salvatore Sanfilippo
+All rights reserved.
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+ * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
Review Comment:
we should care about the redistribution requirements here. Do we check the compatibility with ASL v2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org