You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mbeckerle (via GitHub)" <gi...@apache.org> on 2023/01/23 16:19:59 UTC
[GitHub] [daffodil] mbeckerle opened a new pull request, #928: Changed NYI to SDE
mbeckerle opened a new pull request, #928:
URL: https://github.com/apache/daffodil/pull/928
Activated tests, made them expect an error.
DAFFODIL-847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on a diff in pull request #928: Changed NYI to SDE
Posted by "tuxji (via GitHub)" <gi...@apache.org>.
tuxji commented on code in PR #928:
URL: https://github.com/apache/daffodil/pull/928#discussion_r1084407681
##########
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml:
##########
@@ -1520,49 +1520,31 @@
</tdml:infoset>
</tdml:parserTestCase>
-
- <!--
- Test Name: textStandardDecimalSeparator10
- Schema: textNumberPattern
- Root: tnp26
- Purpose: This test demonstrates that textStandardDecimalSeparator can be a whitespace-separated list of
- single characters that appear (individually) in the data as the decimal separator
- -->
Review Comment:
Even though this comment and the next one were outdated, why were they deleted instead of updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on a diff in pull request #928: Changed NYI to SDE
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle commented on code in PR #928:
URL: https://github.com/apache/daffodil/pull/928#discussion_r1084415823
##########
daffodil-test/src/test/resources/org/apache/daffodil/section13/text_number_props/TextNumberProps.tdml:
##########
@@ -1520,49 +1520,31 @@
</tdml:infoset>
</tdml:parserTestCase>
-
- <!--
- Test Name: textStandardDecimalSeparator10
- Schema: textNumberPattern
- Root: tnp26
- Purpose: This test demonstrates that textStandardDecimalSeparator can be a whitespace-separated list of
- single characters that appear (individually) in the data as the decimal separator
- -->
Review Comment:
I believe these block comments, which just restate what is obvious from the test itself, serve no purpose.
I will change the test names however, to better reflect the specific thing they are testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle merged pull request #928: Changed NYI to SDE
Posted by "mbeckerle (via GitHub)" <gi...@apache.org>.
mbeckerle merged PR #928:
URL: https://github.com/apache/daffodil/pull/928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org