You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Sanjana RK <sa...@gmail.com> on 2023/11/22 13:12:31 UTC
Request approving Pull request
Hello Gary,
As a part of my assignment and personal passion and interest I chose to
work on Apache commons, it would be really helpful if you could approve at
least a few PR's as I have worked my best and I am ready to adhere to your
reviews and rectify the current changes if needed.
Please help me here, the following are the pull requests:
https://github.com/apache/commons-dbutils/pull/220 (This PR contains the
changes, and I have rectified the changes as expected by you. Additionally,
I would like to add that all the quality checks have been passed for the
code changes in this particular case).
https://github.com/apache/commons-dbutils/pull/218
<https://github.com/apache/commons-dbutils/pull/218>
https://github.com/apache/commons-dbutils/pull/219
Your support to developers like me is greatly appreciated.
Thank you.
Best Regards,
Sanjana Rampur Kottur
Re: Request approving Pull request
Posted by Glavo <zj...@gmail.com>.
Hello Gary,
Can you also review this PR (
https://github.com/apache/commons-compress/pull/378) again?
Thank you so much!
Glavo
On Thu, Nov 23, 2023 at 12:45 AM Gary Gregory <ga...@gmail.com>
wrote:
> Hi CommonsSanjana Rampur Kottur,
>
> The key is patience here. We are volunteers here doing our best juggling
> many tasks. I'll take a look over the weekend and get back to you (this is
> a long holiday weekend starting tomorrow in the US).
>
> TY,
> Gary
>
> On Wed, Nov 22, 2023, 11:41 AM Sanjana RK <sanjanarampurkottur01@gmail.com
> >
> wrote:
>
> > Hello Gary,
> >
> > As a part of my assignment and personal passion and interest I chose to
> > work on Apache commons, it would be really helpful if you could approve
> at
> > least a few PR's as I have worked my best and I am ready to adhere to
> your
> > reviews and rectify the current changes if needed.
> >
> > Please help me here, the following are the pull requests:
> > https://github.com/apache/commons-dbutils/pull/220 (This PR contains the
> > changes, and I have rectified the changes as expected by you.
> Additionally,
> > I would like to add that all the quality checks have been passed for the
> > code changes in this particular case).
> > https://github.com/apache/commons-dbutils/pull/218
> > <https://github.com/apache/commons-dbutils/pull/218>
> > https://github.com/apache/commons-dbutils/pull/219
> >
> > Your support to developers like me is greatly appreciated.
> >
> > Thank you.
> >
> > Best Regards,
> > Sanjana Rampur Kottur
> >
>
Re: Request approving Pull request
Posted by Gary Gregory <ga...@gmail.com>.
Hi CommonsSanjana Rampur Kottur,
The key is patience here. We are volunteers here doing our best juggling
many tasks. I'll take a look over the weekend and get back to you (this is
a long holiday weekend starting tomorrow in the US).
TY,
Gary
On Wed, Nov 22, 2023, 11:41 AM Sanjana RK <sa...@gmail.com>
wrote:
> Hello Gary,
>
> As a part of my assignment and personal passion and interest I chose to
> work on Apache commons, it would be really helpful if you could approve at
> least a few PR's as I have worked my best and I am ready to adhere to your
> reviews and rectify the current changes if needed.
>
> Please help me here, the following are the pull requests:
> https://github.com/apache/commons-dbutils/pull/220 (This PR contains the
> changes, and I have rectified the changes as expected by you. Additionally,
> I would like to add that all the quality checks have been passed for the
> code changes in this particular case).
> https://github.com/apache/commons-dbutils/pull/218
> <https://github.com/apache/commons-dbutils/pull/218>
> https://github.com/apache/commons-dbutils/pull/219
>
> Your support to developers like me is greatly appreciated.
>
> Thank you.
>
> Best Regards,
> Sanjana Rampur Kottur
>