You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2015/03/10 18:18:29 UTC
[GitHub] storm pull request: [STORM-625] Don't leak netty clients when work...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/461
[STORM-625] Don't leak netty clients when worker moves or reuse netty client.
- Adding tracking of netty connection by key and reuse whenever client is available.
- Fix included original changes from #455.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm storm625
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/461.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #461
----
commit 5be9e9d9cfe6fb497a7706308cc9c59061215cea
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2015-03-03T22:34:53Z
STORM-625: don't leak netty clients when workers move
commit 14bc9ce73bfe7aa4e46c06eefac102ed693e40c8
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-10T16:32:21Z
Merge branch 'STORM-625' of https://github.com/revans2/incubator-storm into storm625
commit b02f612498b6310d41c0d5fb15d92300c8179094
Author: Kishor Patil <kp...@yahoo-inc.com>
Date: 2015-03-10T17:14:09Z
Reuse netty client in case worker already has one.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-625] Don't leak netty clients when work...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/461#issuecomment-78291337
+1, but since some of the code came from me another committer is going to need to give a +1 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-625] Don't leak netty clients when work...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/461#issuecomment-79108670
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-625] Don't leak netty clients when work...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/461#issuecomment-79189002
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-625] Don't leak netty clients when work...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---