You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/10 15:17:35 UTC
[GitHub] [airflow] repocho opened a new pull request #17537: Extend init_containers defined in pod_override
repocho opened a new pull request #17537:
URL: https://github.com/apache/airflow/pull/17537
If you add an init_container in pod_override the specified init_containers in the pod-template-file for kubernetes are ovewritten instead of extended as it is the case of the volumes for example.
So, for example, if you have a git sync ini_container but you define another init container, the task won't be executed because airflow won't find the dags as the init_container is replaced.
This change is just extending the init_container defined in the pod_override with the existing ones defined in the pod template file for kubernetes. In that sense you can define new extra init_containers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-902027046
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-897993920
Thanks @jedcunningham, I have merged your suggestions and launched the tests again with success.
```
tests/kubernetes/test_pod_generator.py::TestPodGenerator::test_reconcile_specs_init_containers PASSED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr closed pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
uranusjr closed pull request #17537:
URL: https://github.com/apache/airflow/pull/17537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-902027971
Thanks for the bugfix @repocho and congrats on your first commit π!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #17537:
URL: https://github.com/apache/airflow/pull/17537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
subkanthi commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689213294
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
The concern is more on line 291 where merged_spec is passed to the function and the return value is assigned back to merged_spec, someone making change in the future might not notice it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-897093972
Thanks @repocho! Can you add a test for this in [tests/kubernetes/test_pod_generator.py](https://github.com/apache/airflow/blob/main/tests/kubernetes/test_pod_generator.py)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690465246
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
So, then we keep the current code ?
Do you agree @subkanthi ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] subkanthi commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
subkanthi commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689071238
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
can this be renamed to merged_volume_spec and merged_init_container_spec for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690424705
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
I'm good with either `extended_spec` or `merged_spec`. The variable is only in play for 3 lines anyways π€·ββοΈ.
(I don't think we should deepcopy it explicitly)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-898611803
Oh, looks like we have a static check failure in that test file. Can you reformat that when you get the chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689077597
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
Hello, thanks for the suggestion, but I think doing that will be less clear because it will be something like this:
```
merged_init_container_spec = extend_object_field(
base_spec,
client_spec,
'init_containers')
merged_volume_spec = extend_object_field(
base_spec,
merged_init_container_spec,
'volumes')
return merge_objects(base_spec, merged_volume_spec)
```
My idea was that you have a `base_spec`, a `client_spec` and you get a `merged_spec` extending both volumes and init_containers. Finally, you merge the object, by overwriting the `base_spec` with the `merged_spec`.
But please, let me know if you see it differently or you have a better approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690100895
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -113,7 +113,7 @@ create a V1pod with a single container, and overwrite the fields as follows:
:start-after: [START task_with_volume]
:end-before: [END task_with_volume]
-Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten.
+Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten. Note also that the volumes and the init_containers from the spec will be extended.
Review comment:
The first note refers to the container, and the one that I have added to the spec. I will try to rephrase it a little bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690279275
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -113,7 +113,7 @@ create a V1pod with a single container, and overwrite the fields as follows:
:start-after: [START task_with_volume]
:end-before: [END task_with_volume]
-Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten.
+Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten. Note also that the volumes and the init_containers from the spec will be extended.
Review comment:
Please check new changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-903043492
Thank you for all your help !! π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690424926
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -113,7 +113,7 @@ create a V1pod with a single container, and overwrite the fields as follows:
:start-after: [START task_with_volume]
:end-before: [END task_with_volume]
-Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten.
+Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten. Note also that the volumes and the init_containers from the spec will be extended.
Review comment:
That works. I'm not sure the distinction really matters though π€·ββοΈ
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-896118056
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r688107979
##########
File path: tests/kubernetes/test_pod_generator.py
##########
@@ -631,6 +631,15 @@ def test_reconcile_specs(self):
client_spec.active_deadline_seconds = 100
assert client_spec == res
+ def test_reconcile_specs_init_containers(self):
+ base_objs = [k8s.V1Container(name='base_container1')]
+ client_objs = [k8s.V1Container(name='client_container1')]
+ base_spec = k8s.V1PodSpec(priority=1, containers=[], init_containers=base_objs)
+ client_spec = k8s.V1PodSpec(priority=2, containers=[], init_containers=client_objs)
Review comment:
```suggestion
base_spec = k8s.V1PodSpec(containers=[], init_containers=[k8s.V1Container(name='base_container1')])
client_spec = k8s.V1PodSpec(containers=[], init_containers=[k8s.V1Container(name='client_container1')])
```
Do we need `priority`? Does this work instead?
##########
File path: tests/kubernetes/test_pod_generator.py
##########
@@ -631,6 +631,15 @@ def test_reconcile_specs(self):
client_spec.active_deadline_seconds = 100
assert client_spec == res
+ def test_reconcile_specs_init_containers(self):
+ base_objs = [k8s.V1Container(name='base_container1')]
+ client_objs = [k8s.V1Container(name='client_container1')]
+ base_spec = k8s.V1PodSpec(priority=1, containers=[], init_containers=base_objs)
+ client_spec = k8s.V1PodSpec(priority=2, containers=[], init_containers=client_objs)
+ res = PodGenerator.reconcile_specs(base_spec, client_spec)
+ client_spec.init_containers = base_spec.init_containers + client_spec.init_containers
+ assert client_spec == res
Review comment:
```suggestion
assert res.init_containers == base_spec.init_containers + client_spec.init_containers
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r689592667
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -113,7 +113,7 @@ create a V1pod with a single container, and overwrite the fields as follows:
:start-after: [START task_with_volume]
:end-before: [END task_with_volume]
-Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten.
+Note that volume mounts, environment variables, ports, and devices will all be extended instead of overwritten. Note also that the volumes and the init_containers from the spec will be extended.
Review comment:
Good call. I'd just add these 2 to the first list though? I don't think we need it separate?
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
I'm looking at `extend_object_field`'s use in `reconcile_metadata`, maybe it'd be more clear like this:
```
extend_object_field(base_spec, client_spec, 'init_containers')
extend_object_field(base_spec, client_spec, 'volumes')
return merge_objects(base_spec, client_spec)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on a change in pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on a change in pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#discussion_r690104400
##########
File path: airflow/kubernetes/pod_generator.py
##########
@@ -287,7 +287,8 @@ def reconcile_specs(
client_spec.containers = PodGenerator.reconcile_containers(
base_spec.containers, client_spec.containers
)
- merged_spec = extend_object_field(base_spec, client_spec, 'volumes')
+ merged_spec = extend_object_field(base_spec, client_spec, 'init_containers')
+ merged_spec = extend_object_field(base_spec, merged_spec, 'volumes')
Review comment:
I'm not an expert in python, but looking into the function `extend_object_field` it seems that is returning a copy and not changing any of the arguments. So I don't know exactly how reconcile_metatadata is working but if I change the code to this:
```
extend_object_field(base_spec, client_spec, 'init_containers')
extend_object_field(base_spec, client_spec, 'volumes')
return merge_objects(base_spec, client_spec)
```
The test fails:
`tests/kubernetes/test_pod_generator.py::TestPodGenerator::test_reconcile_specs_init_containers FAILED [ 96%]`
I've thinking another less confusing code and it could be this:
```
extended_spec = copy.deepcopy(client_spec)
extended_spec = extend_object_field(base_spec, extended_spec, 'init_containers')
extended_spec = extend_object_field(base_spec, extended_spec, 'volumes')
return merge_objects(base_spec, extended_spec)
```
What do you think?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-897230204
Thanks for the time reviewing this PR @jedcunningham !
I have added a test for this. Let me know if you need anything more.
Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] repocho commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
repocho commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-899023068
I have rebased the branch with the last changes in branch main, to be able to launch all the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17537: Extend init_containers defined in pod_override
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17537:
URL: https://github.com/apache/airflow/pull/17537#issuecomment-898691378
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org