You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/06/24 07:30:31 UTC
[GitHub] [incubator-linkis] casionone opened a new pull request, #2336: Fix the license of ras.js
casionone opened a new pull request, #2336:
URL: https://github.com/apache/incubator-linkis/pull/2336
### What is the purpose of the change
Adjust the encryption and decryption method when logging in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2336: Fix the license of ras.js
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2336:
URL: https://github.com/apache/incubator-linkis/pull/2336#discussion_r905875764
##########
web/src/dss/view/login/index.vue:
##########
@@ -117,22 +117,23 @@ export default {
this.loginForm.user = this.loginForm.user.toLocaleLowerCase();
// 需要判断是否需要给密码加密
let password = this.loginForm.password;
- let params = {};
- if (this.publicKeyData && this.publicKeyData.enableLoginEncrypt) {
- const key = RSA.getPublicKey(`-----BEGIN PUBLIC KEY-----${this.publicKeyData.publicKey}-----END PUBLIC KEY-----`);
- password = RSA.encrypt(this.loginForm.password, key);
- params = {
- userName: this.loginForm.user,
- passwdEncrypt: password,
Review Comment:
The server can be compatible with these two parameter names [passwdEncrypt/password]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2336: Fix the license of ras.js
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2336:
URL: https://github.com/apache/incubator-linkis/pull/2336#issuecomment-1165307986
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2336](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a160c7) into [dev-1.1.2](https://codecov.io/gh/apache/incubator-linkis/commit/4830ad8552823a2b5b931bfaf930800cd956187b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4830ad8) will **decrease** coverage by `0.37%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.1.2 #2336 +/- ##
===============================================
- Coverage 19.44% 19.07% -0.38%
+ Complexity 989 826 -163
===============================================
Files 440 383 -57
Lines 13280 11819 -1461
Branches 2154 1757 -397
===============================================
- Hits 2582 2254 -328
+ Misses 10359 9329 -1030
+ Partials 339 236 -103
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/linkis/jobhistory/util/QueryUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvam9iaGlzdG9yeS91dGlsL1F1ZXJ5VXRpbHMuc2NhbGE=) | `17.91% <0.00%> (-5.08%)` | :arrow_down: |
| [...s/governance/common/conf/GovernaceCommonConf.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UtY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGlua2lzL2dvdmVybmFuY2UvY29tbW9uL2NvbmYvR292ZXJuYWNlQ29tbW9uQ29uZi5zY2FsYQ==) | `93.75% <0.00%> (-0.70%)` | :arrow_down: |
| [...linkis/jobhistory/restful/api/QueryRestfulApi.java](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9qb2JoaXN0b3J5L3Jlc3RmdWwvYXBpL1F1ZXJ5UmVzdGZ1bEFwaS5qYXZh) | `42.71% <0.00%> (-0.64%)` | :arrow_down: |
| [.../org/apache/linkis/common/conf/Configuration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vY29uZi9Db25maWd1cmF0aW9uLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...org/apache/linkis/common/utils/VariableUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9jb21tb24vdXRpbHMvVmFyaWFibGVVdGlscy5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [...inkis/ecm/core/launch/EngineConnLaunchRunner.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4tbWFuYWdlci9saW5raXMtZW5naW5lY29ubi1tYW5hZ2VyLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvZWNtL2NvcmUvbGF1bmNoL0VuZ2luZUNvbm5MYXVuY2hSdW5uZXIuc2NhbGE=) | | |
| [...pache/linkis/scheduler/queue/ConsumerManager.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvQ29uc3VtZXJNYW5hZ2VyLnNjYWxh) | | |
| [.../scala/org/apache/linkis/scheduler/Scheduler.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvU2NoZWR1bGVyLnNjYWxh) | | |
| [...org/apache/linkis/scheduler/SchedulerContext.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvU2NoZWR1bGVyQ29udGV4dC5zY2FsYQ==) | | |
| [...linkis/ecm/core/listener/ECMAsyncListenerBus.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbXB1dGF0aW9uLWdvdmVybmFuY2UvbGlua2lzLWVuZ2luZWNvbm4tbWFuYWdlci9saW5raXMtZW5naW5lY29ubi1tYW5hZ2VyLWNvcmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9saW5raXMvZWNtL2NvcmUvbGlzdGVuZXIvRUNNQXN5bmNMaXN0ZW5lckJ1cy5zY2FsYQ==) | | |
| ... and [53 more](https://codecov.io/gh/apache/incubator-linkis/pull/2336/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4830ad8...5a160c7](https://codecov.io/gh/apache/incubator-linkis/pull/2336?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2336: Fix the license of ras.js
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2336:
URL: https://github.com/apache/incubator-linkis/pull/2336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org