You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by kb...@apache.org on 2024/01/02 11:54:49 UTC
(incubator-kie-tools) branch kie-issues#399 created (now 8bbe71a0678)
This is an automated email from the ASF dual-hosted git repository.
kbowers pushed a change to branch kie-issues#399
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
at 8bbe71a0678 adding missing dependencies
This branch includes the following new commits:
new 8bbe71a0678 adding missing dependencies
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
(incubator-kie-tools) 01/01: adding missing dependencies
Posted by kb...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
kbowers pushed a commit to branch kie-issues#399
in repository https://gitbox.apache.org/repos/asf/incubator-kie-tools.git
commit 8bbe71a0678ffa215b3ff0caa7359c82d41955cd
Author: Kennedy Bowers <ke...@ibm.com>
AuthorDate: Tue Jan 2 12:52:21 2024 +0100
adding missing dependencies
---
.../src/app/components/common/GitHubContext.tsx | 6 ++---
.../app/components/common/KogitoEditorIframe.tsx | 8 +++---
.../src/app/components/common/KogitoMenu.tsx | 31 ++++++++++++----------
3 files changed, 24 insertions(+), 21 deletions(-)
diff --git a/packages/chrome-extension/src/app/components/common/GitHubContext.tsx b/packages/chrome-extension/src/app/components/common/GitHubContext.tsx
index 8d249abf3bc..1c14f1e6a5b 100644
--- a/packages/chrome-extension/src/app/components/common/GitHubContext.tsx
+++ b/packages/chrome-extension/src/app/components/common/GitHubContext.tsx
@@ -62,7 +62,7 @@ export const GitHubContextProvider: React.FC<{}> = (props) => {
const userIsLoggedIn = useCallback(() => {
return !!globals.dependencies.all.notificationIndicator();
- }, []);
+ }, [globals.dependencies.all]);
const octokit = useCallback(() => {
return octokitInstance;
@@ -77,7 +77,7 @@ export const GitHubContextProvider: React.FC<{}> = (props) => {
console.debug("Token not found.");
}
setReady(true);
- }, []);
+ }, [token]);
useLayoutEffect(() => {
if (!token) {
@@ -87,7 +87,7 @@ export const GitHubContextProvider: React.FC<{}> = (props) => {
setCookie(globals.githubAuthTokenCookieName, token);
octokitInstance = new Octokit({ auth: token });
}
- }, [token]);
+ }, [globals.githubAuthTokenCookieName, token]);
return (
<GitHubContext.Provider value={{ token, setToken, octokit, userIsLoggedIn }}>
diff --git a/packages/chrome-extension/src/app/components/common/KogitoEditorIframe.tsx b/packages/chrome-extension/src/app/components/common/KogitoEditorIframe.tsx
index f9324734859..9257d4da4f0 100644
--- a/packages/chrome-extension/src/app/components/common/KogitoEditorIframe.tsx
+++ b/packages/chrome-extension/src/app/components/common/KogitoEditorIframe.tsx
@@ -58,7 +58,7 @@ const RefForwardingKogitoEditorIframe: React.ForwardRefRenderFunction<IsolatedEd
const resourceContentService = useMemo(() => {
return resourceContentServiceFactory.createNew(githubApi.octokit(), repoInfo);
- }, [repoInfo]);
+ }, [githubApi, repoInfo, resourceContentServiceFactory]);
const onResourceContentRequest = useCallback(
(request: ResourceContentRequest) => resourceContentService.get(request.path, request.opts),
@@ -85,7 +85,7 @@ const RefForwardingKogitoEditorIframe: React.ForwardRefRenderFunction<IsolatedEd
if (!textMode && wasOnTextMode) {
props.getFileContents().then((content) => editor?.setContent(props.contentPath, content ?? ""));
}
- }, [textMode, wasOnTextMode, editor]);
+ }, [textMode, wasOnTextMode, editor, props]);
// When !textMode, we should listen for changes on the diagram to update GitHub's default text editor.
useEffect(() => {
@@ -104,7 +104,7 @@ const RefForwardingKogitoEditorIframe: React.ForwardRefRenderFunction<IsolatedEd
});
});
return () => editor.getStateControl().unsubscribe(stateControlSubscription);
- }, [textMode, editor]);
+ }, [textMode, editor, props.readonly]);
// Forward reference methods to set content programmatically vs property
useImperativeHandle(
@@ -118,7 +118,7 @@ const RefForwardingKogitoEditorIframe: React.ForwardRefRenderFunction<IsolatedEd
setContent: (content: string) => editor.setContent(props.contentPath, content),
};
},
- [editor]
+ [editor, props.contentPath]
);
return (
diff --git a/packages/chrome-extension/src/app/components/common/KogitoMenu.tsx b/packages/chrome-extension/src/app/components/common/KogitoMenu.tsx
index 1c78265aa2f..69a192917e0 100644
--- a/packages/chrome-extension/src/app/components/common/KogitoMenu.tsx
+++ b/packages/chrome-extension/src/app/components/common/KogitoMenu.tsx
@@ -54,19 +54,22 @@ export function KogitoMenu() {
updateToken(gitHubApi.token).then(() => {
console.debug("Checked GitHub token.");
});
- }, []);
-
- const onPaste = useCallback((e) => {
- const token = e.clipboardData.getData("text/plain").slice(0, GITHUB_OAUTH_TOKEN_SIZE);
- setPotentialToken(token);
- setTimeout(async () => {
- const wasValid = await updateToken(token);
- if (wasValid) {
- setTimeout(() => setWholeMenuOpen(false), 2000);
- }
- inputRef.current!.setSelectionRange(0, 0);
- }, 0);
- }, []);
+ }, [gitHubApi.token, updateToken]);
+
+ const onPaste = useCallback(
+ (e) => {
+ const token = e.clipboardData.getData("text/plain").slice(0, GITHUB_OAUTH_TOKEN_SIZE);
+ setPotentialToken(token);
+ setTimeout(async () => {
+ const wasValid = await updateToken(token);
+ if (wasValid) {
+ setTimeout(() => setWholeMenuOpen(false), 2000);
+ }
+ inputRef.current!.setSelectionRange(0, 0);
+ }, 0);
+ },
+ [updateToken]
+ );
const onReset = useCallback(() => {
gitHubApi.setToken("");
@@ -74,7 +77,7 @@ export function KogitoMenu() {
setTimeout(() => {
inputRef.current!.focus();
}, 0);
- }, []);
+ }, [gitHubApi]);
const toggleInfoPopOver = useCallback(() => {
setInfoPopOverOpen(!isInfoPopOverOpen);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org