You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "rthomas320 (via GitHub)" <gi...@apache.org> on 2024/08/13 14:19:58 UTC

[PR] Slash space fix [daffodil-vscode]

rthomas320 opened a new pull request, #1078:
URL: https://github.com/apache/daffodil-vscode/pull/1078

   Fixes a problem where a space or slash typed in a quoted attribute value for attributes without pre-defined values removes the quoted text. Also fixes a problem where a slash typed almost anywhere in the schema will insert '/>' the self closing end tag.
   
   Description from Mike Beckerle's email:
   
   > (blocking) There is a real problem with "/" being typed. I know it is trying to detect closing the element, but it has to be context sensitive since "/" is such a common character to appear inside strings.
   To reproduce, at the top level of the schema, try typing <xs:include schemaLocation="/ I.e., a string that begins with a "/" character. The GUI refuses to let you do this. It removes the quotation marks and anything you've typed inside them.
   So I tried typing <xs:include schemaLocation="" /> then going back and putting a "/" inside the quotes. Again the editor refuses, removes the quotes, remotes the "/" just typed.
   I tried using single quotes, no improvement.
   I tried typing some characters e.g., 'abc/ It still immediately reacts to the "/" character being typed, and deletes the string and quotation mark.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Slash space fix [daffodil-vscode]

Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #1078:
URL: https://github.com/apache/daffodil-vscode/pull/1078#issuecomment-2343619174

   @rthomas320, please rebase this to pass CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Slash space fix [daffodil-vscode]

Posted by "rthomas320 (via GitHub)" <gi...@apache.org>.
rthomas320 closed pull request #1078: Slash space fix
URL: https://github.com/apache/daffodil-vscode/pull/1078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org