[GitHub] [airflow] joppevos commented on a diff in pull request #22901: Catch error in Breeze when docker is not running

[GitBox <gi...@apache.org>]

joppevos commented on code in PR #22901:
URL: https://github.com/apache/airflow/pull/22901#discussion_r847235044


##########
dev/breeze/src/airflow_breeze/utils/docker_command_utils.py:
##########
@@ -179,11 +179,7 @@ def check_docker_version(verbose: bool):
             text=True,
         )
         if not docker_version_output:
-            console.print(
-                '[red]ERROR[/] Docker version could not be determined. Please make sure Docker is installed '
-                'and running.'
-            )
-            return
+            raise Exception("No running Docker instance found")

Review Comment:
   Thanks for the information. 
   I implemented the changes. We now have a more graceful and helpful message :)
   
   ```shell
   > python3 dev/breeze/src/airflow_breeze/breeze.py
   Docker is not running.
   Please make sure Docker is installed and running.
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org