[GitHub] [kafka] mimaison commented on a diff in pull request #13649: MINOR: Fix incorrect description of SessionLifetimeMs

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #13649:
URL: https://github.com/apache/kafka/pull/13649#discussion_r1179439738


##########
clients/src/main/resources/common/message/SaslAuthenticateResponse.json:
##########
@@ -29,6 +29,6 @@
     { "name": "AuthBytes", "type": "bytes", "versions": "0+",
       "about": "The SASL authentication bytes from the server, as defined by the SASL mechanism." },
     { "name": "SessionLifetimeMs", "type": "int64", "versions": "1+", "default": "0", "ignorable": true,
-      "about": "The SASL authentication bytes from the server, as defined by the SASL mechanism." }
+      "about": "The duration in milliseconds that a successful session response is valid for." }

Review Comment:
   Maybe we can reuse the original message?
   https://github.com/apache/kafka/blob/2.2/clients/src/main/java/org/apache/kafka/common/requests/SaslAuthenticateResponse.java#L51



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org