Jenkins build became unstable: beam_PostCommit_Java_RunnableOnService_Apex #4

[Apache Jenkins Server <je...@builds.apache.org>]

See <https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Apex/4/changes>

Re: Jenkins build became unstable: beam_PostCommit_Java_RunnableOnService_Apex #4

[Kenneth Knowles <kl...@google.com.INVALID>]

I thought it was a simple race condition with write & assert, but now I'm
not so sure. Let's see how it goes.

And actually, it is in examples.WordCountTest but has no dependencies on
examples, etc. It seems fine as a little smoke test in ApexRunnerTest, for
example. The namespace and class name threw me off a bit.

But I don't think we really need to duplicate things like this. I'd rather
make it really easy to run [subsets of] the RunnableOnService suites and
WordCount integration tests with each runner. Right now it is a moderate
pain with mvn but I'm not sure how much better it can get. I have my own
little gist for keeping commands like:

mvn --errors failsafe:integration-test@apex-runner-integration-tests \
    -pl examples/java \
    -P
jenkins-precommit,apex-runner,spark-runner,flink-runner,dataflow-runner,direct-runner
\
    -D test=WordCountIT \
    -D beamTestPipelineOptions='[
      "--runner=org.apache.beam.runners.apex.TestApexRunner",
      "--project=...",
      "--tempRoot=..."
    ]'

Which I think of as just `make apex-runner-integration-tests` (modulo test
filter). It runs quickly and gives roughly the same feedback.

I've been dumping these commands onto PRs when I use them. We might want to
document them or just make a good shared gist.

On Thu, Dec 15, 2016 at 12:58 PM, Thomas Weise <th...@apache.org> wrote:

> Hi Kenn,
>
> You could mark it @Ignored. I would prefer to keep and fix it as it runs as
> part of the unit tests and provides basic coverage early on. If you have
> already ideas what is wrong with it please let me know. This test was seen
> as flaky before.
>
> Thanks,
> Thomas
>
>
> On Thu, Dec 15, 2016 at 12:53 PM, Kenneth Knowles <kl...@google.com.invalid>
> wrote:
>
> > This build job is new - I just added it - so it is expected that we'll
> have
> > to shake some stuff out.
> >
> > Looking at the failure, it is
> > in org.apache.beam.runners.apex.examples.WordCountTest
> >
> > I have ideas what is wrong - and I think it is just the test - but this
> is
> > now redundant with how we run org.apache.beam.examples.WordCountTest,
> > right? So I'm hoping we can just delete it!
> >
> > On Thu, Dec 15, 2016 at 12:18 PM, Apache Jenkins Server <
> > jenkins@builds.apache.org> wrote:
> >
> > > See <https://builds.apache.org/job/beam_PostCommit_Java_
> > > RunnableOnService_Apex/4/changes>
> > >
> > >
> >
>

Re: Jenkins build became unstable: beam_PostCommit_Java_RunnableOnService_Apex #4

[Thomas Weise <th...@apache.org>]

Hi Kenn,

You could mark it @Ignored. I would prefer to keep and fix it as it runs as
part of the unit tests and provides basic coverage early on. If you have
already ideas what is wrong with it please let me know. This test was seen
as flaky before.

Thanks,
Thomas


On Thu, Dec 15, 2016 at 12:53 PM, Kenneth Knowles <kl...@google.com.invalid>
wrote:

> This build job is new - I just added it - so it is expected that we'll have
> to shake some stuff out.
>
> Looking at the failure, it is
> in org.apache.beam.runners.apex.examples.WordCountTest
>
> I have ideas what is wrong - and I think it is just the test - but this is
> now redundant with how we run org.apache.beam.examples.WordCountTest,
> right? So I'm hoping we can just delete it!
>
> On Thu, Dec 15, 2016 at 12:18 PM, Apache Jenkins Server <
> jenkins@builds.apache.org> wrote:
>
> > See <https://builds.apache.org/job/beam_PostCommit_Java_
> > RunnableOnService_Apex/4/changes>
> >
> >
>

Re: Jenkins build became unstable: beam_PostCommit_Java_RunnableOnService_Apex #4

[Kenneth Knowles <kl...@google.com.INVALID>]

This build job is new - I just added it - so it is expected that we'll have
to shake some stuff out.

Looking at the failure, it is
in org.apache.beam.runners.apex.examples.WordCountTest

I have ideas what is wrong - and I think it is just the test - but this is
now redundant with how we run org.apache.beam.examples.WordCountTest,
right? So I'm hoping we can just delete it!

On Thu, Dec 15, 2016 at 12:18 PM, Apache Jenkins Server <
jenkins@builds.apache.org> wrote:

> See <https://builds.apache.org/job/beam_PostCommit_Java_
> RunnableOnService_Apex/4/changes>
>
>

Jenkins build is back to stable : beam_PostCommit_Java_RunnableOnService_Apex #5

[Apache Jenkins Server <je...@builds.apache.org>]

See <https://builds.apache.org/job/beam_PostCommit_Java_RunnableOnService_Apex/5/changes>