You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/06 07:41:11 UTC

[GitHub] [spark] kiszk opened a new pull request #24308: [SPARK-27397[Core] Take care of OpenJ9 JVM in Spark

kiszk opened a new pull request #24308: [SPARK-27397[Core] Take care of OpenJ9 JVM in Spark
URL: https://github.com/apache/spark/pull/24308
 
 
   ## What changes were proposed in this pull request?
   
   This PR supports `OpenJ9` in addition to `IBM JDK` and `OpenJDK` in Spark by handling `System.getProperty("java.vendor") = "Eclipse OpenJ9"`.  
   In other places where see `System.getProperty("java.vendor")`, we can leave alone.
   
   ```
   $ ~/jdk-11.0.2+9_openj9-0.12.1/bin/jshell 
   |  Welcome to JShell -- Version 11.0.2
   |  For an introduction type: /help intro
   
   jshell> System.out.println(System.getProperty("java.vendor"))
   Eclipse OpenJ9
   
   jshell> System.out.println(System.getProperty("java.vm.info"))
   JRE 11 Linux amd64-64-Bit Compressed References 20190204_127 (JIT enabled, AOT enabled)
   OpenJ9   - 90dd8cb40
   OMR      - d2f4534b
   JCL      - 289c70b6844 based on jdk-11.0.2+9
   
   jshell> System.out.println(Class.forName("com.ibm.lang.management.OperatingSystemMXBean").getDeclaredMethod("getTotalPhysicalMemory"))
   public abstract long com.ibm.lang.management.OperatingSystemMXBean.getTotalPhysicalMemory()
   
   jshell> System.out.println(Class.forName("com.sun.management.OperatingSystemMXBean").getDeclaredMethod("getTotalPhysicalMemorySize"))
   public abstract long com.sun.management.OperatingSystemMXBean.getTotalPhysicalMemorySize()
   
   jshell> System.out.println(Class.forName("com.ibm.security.auth.module.Krb5LoginModule"))
   |  Exception java.lang.ClassNotFoundException: com.ibm.security.auth.module.Krb5LoginModule
   |        at Class.forNameImpl (Native Method)
   |        at Class.forName (Class.java:339)
   |        at (#1:1)
   
   jshell> System.out.println(Class.forName("com.sun.security.auth.module.Krb5LoginModule"))
   class com.sun.security.auth.module.Krb5LoginModule
   ```
   
   ## How was this patch tested?
   
   Existing test suites

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org