You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2001/01/24 22:15:52 UTC

Re: cvs commit: apr/file_io/unix filestat.c

> trawick     01/01/24 13:11:52
> 
>   Modified:    file_io/unix filestat.c
>   Log:
>   get filestat.c to compile again

and it rides again, I presume?  Thanks Jeff


Re: cvs commit: apr/file_io/unix filestat.c

Posted by Jeff Trawick <tr...@bellsouth.net>.
Jeff Trawick <tr...@bellsouth.net> writes:

> "William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> 
> > > trawick     01/01/24 13:11:52
> > > 
> > >   Modified:    file_io/unix filestat.c
> > >   Log:
> > >   get filestat.c to compile again
> > 
> > and it rides again, I presume?  Thanks Jeff
> 
> autoindex is still failing for me; I'll play with it some more

I found and fixed a bug in the threaded leg of apr_dir_read().  This
makes me real happy, because...

I started the day perplexed because it seemed that autoindex failed in
a pthread build but not in a prefork build.  Before I got a chance to
debug, I updated my normal work area -- picking up a bug which broke
both builds -- and went to work using prefork to verify that it really
worked with prefork.  But at this point it failed with prefork, so I
debugged, found the problem, and you committed a fix.  But I later got
e-mails from the regression test machines saying that the autoindex
test is still failing.  Again I noted the prefork vs. mpmt_pthread
discrepancy, yada yada yada...

Hopefully now autoindex really is working on Unix -- threaded build or
not :)
-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Re: cvs commit: apr/file_io/unix filestat.c

Posted by Bill Stoddard <bi...@wstoddard.com>.
Fails for me too (NT sp5).  And I believe it is the apr_stat call that is
failing on "e:\website\." (notice the .)

Bill


> That's odd - it works flawlessly for me.
>
> The bug's gotta be in apr_stat, since I mod_autoindex looks at nothing
> but the filename and creates the subrequest to parse each file entry.
> Hmmm... could be the apr_lstat variety, better be sure we clear that
> flag out.  I'm thinking that ->valid |= APR_FINFO_STAT should tell the
> user we did an lstat() instead of a stat(), and leave the APR_LNK flag
> to tell them that it was (or wasn't) a link.
>
> Maybe that's the bit that's fooling us all.
>
> Bill
>
> ----- Original Message -----
> From: "Jeff Trawick" <tr...@bellsouth.net>
> To: "William A. Rowe, Jr." <wr...@rowe-clan.net>
> Cc: <de...@apr.apache.org>
> Sent: Wednesday, January 24, 2001 4:01 PM
> Subject: Re: cvs commit: apr/file_io/unix filestat.c
>
>
> > "William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> >
> > > > trawick     01/01/24 13:11:52
> > > >
> > > >   Modified:    file_io/unix filestat.c
> > > >   Log:
> > > >   get filestat.c to compile again
> > >
> > > and it rides again, I presume?  Thanks Jeff
> >
> > autoindex is still failing for me; I'll play with it some more
> >
> > --
> > Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
> >        http://www.geocities.com/SiliconValley/Park/9289/
> >              Born in Roswell... married an alien...
> >
>


Re: cvs commit: apr/file_io/unix filestat.c

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
That's odd - it works flawlessly for me.

The bug's gotta be in apr_stat, since I mod_autoindex looks at nothing
but the filename and creates the subrequest to parse each file entry.
Hmmm... could be the apr_lstat variety, better be sure we clear that
flag out.  I'm thinking that ->valid |= APR_FINFO_STAT should tell the
user we did an lstat() instead of a stat(), and leave the APR_LNK flag 
to tell them that it was (or wasn't) a link.

Maybe that's the bit that's fooling us all.

Bill

----- Original Message ----- 
From: "Jeff Trawick" <tr...@bellsouth.net>
To: "William A. Rowe, Jr." <wr...@rowe-clan.net>
Cc: <de...@apr.apache.org>
Sent: Wednesday, January 24, 2001 4:01 PM
Subject: Re: cvs commit: apr/file_io/unix filestat.c


> "William A. Rowe, Jr." <wr...@rowe-clan.net> writes:
> 
> > > trawick     01/01/24 13:11:52
> > > 
> > >   Modified:    file_io/unix filestat.c
> > >   Log:
> > >   get filestat.c to compile again
> > 
> > and it rides again, I presume?  Thanks Jeff
> 
> autoindex is still failing for me; I'll play with it some more
> 
> -- 
> Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
>        http://www.geocities.com/SiliconValley/Park/9289/
>              Born in Roswell... married an alien...
> 


Re: cvs commit: apr/file_io/unix filestat.c

Posted by Jeff Trawick <tr...@bellsouth.net>.
"William A. Rowe, Jr." <wr...@rowe-clan.net> writes:

> > trawick     01/01/24 13:11:52
> > 
> >   Modified:    file_io/unix filestat.c
> >   Log:
> >   get filestat.c to compile again
> 
> and it rides again, I presume?  Thanks Jeff

autoindex is still failing for me; I'll play with it some more

-- 
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...