You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/01/13 22:12:53 UTC
[GitHub] [systemds] DodoTheDeveloper opened a new pull request #1155: [WIP] Bayesian optimisation
DodoTheDeveloper opened a new pull request #1155:
URL: https://github.com/apache/systemds/pull/1155
This Pullrequest implement bayesian optimisation for hyperparameters.
* Currently only a skeleton for the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on a change in pull request #1155: [WIP] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on a change in pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#discussion_r567250677
##########
File path: scripts/staging/bayesian_optimisation/test/bayesianOptimisationSinTest.dml
##########
@@ -0,0 +1,47 @@
+# Test
+source("./scripts/staging/bayesian_optimisation/bayesianOptimisation.dml") as bayOpt;
+
+kernel_gaus = function(Matrix[Double] X1, Matrix[Double] X2, Double variance)
+ return (Matrix[Double] result)
+{
+ #TODO: What to do about multiple dimensional matrix?
Review comment:
Hi,
Just quick feedback, in DML we use two-space indentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] DodoTheDeveloper commented on a change in pull request #1155: [WIP] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
DodoTheDeveloper commented on a change in pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#discussion_r571666707
##########
File path: scripts/staging/bayesian_optimisation/test/bayesianOptimisationSinTest.dml
##########
@@ -0,0 +1,47 @@
+# Test
+source("./scripts/staging/bayesian_optimisation/bayesianOptimisation.dml") as bayOpt;
+
+kernel_gaus = function(Matrix[Double] X1, Matrix[Double] X2, Double variance)
+ return (Matrix[Double] result)
+{
+ #TODO: What to do about multiple dimensional matrix?
Review comment:
Hi and thanks for the Feedback, I applied it in the last commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Baunsgaard commented on pull request #1155: [WIP] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
Baunsgaard commented on pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#issuecomment-774740778
Currently the tests are failing because of missing licenses, these can be simply added at the top of the files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on a change in pull request #1155: [DIA] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on a change in pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#discussion_r582130999
##########
File path: src/test/java/org/apache/sysds/test/functions/builtin/BuiltinBayesianOptimisationTest.java
##########
@@ -1,3 +1,22 @@
+/*
Review comment:
Please reformat the test file. Add some test cases for different parameters of the optimizer such as number of iterations, minimize, and ExecType (CP or SPARK).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] DodoTheDeveloper commented on pull request #1155: [WIP] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
DodoTheDeveloper commented on pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#issuecomment-779090441
@Baunsgaard Thanks, I've added them now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi closed pull request #1155: [DIA] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi closed pull request #1155:
URL: https://github.com/apache/systemds/pull/1155
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1155: [DIA] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
Shafaq-Siddiqi commented on pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#issuecomment-786526216
LGTM,
Hi @DodoTheDeveloper,
Thank you for your contribution. During the merge, I did some minor fixes like formattings, spelling mistakes and Java tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] DodoTheDeveloper commented on pull request #1155: [DIA] Bayesian optimisation
Posted by GitBox <gi...@apache.org>.
DodoTheDeveloper commented on pull request #1155:
URL: https://github.com/apache/systemds/pull/1155#issuecomment-786702942
> LGTM,
> Hi @DodoTheDeveloper,
> Thank you for your contribution. During the merge, I did some minor fixes like formattings, spelling mistakes and Java tests.
Thanks, I didn't see your reply in time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org