You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2024/04/30 09:04:38 UTC
[PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
lidavidm opened a new pull request, #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796
Fixes #1657.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796#discussion_r1584969776
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -39,13 +39,13 @@ import (
driver "github.com/apache/arrow-adbc/go/adbc/driver/flightsql"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
"github.com/apache/arrow-adbc/go/adbc/validation"
- "github.com/apache/arrow/go/v16/arrow"
- "github.com/apache/arrow/go/v16/arrow/array"
- "github.com/apache/arrow/go/v16/arrow/flight"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql/schema_ref"
- flightproto "github.com/apache/arrow/go/v16/arrow/flight/gen/flight"
- "github.com/apache/arrow/go/v16/arrow/memory"
+ "github.com/apache/arrow/go/v17/arrow"
+ "github.com/apache/arrow/go/v17/arrow/array"
+ "github.com/apache/arrow/go/v17/arrow/flight"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql/schema_ref"
+ flightproto "github.com/apache/arrow/go/v17/arrow/flight/gen/flight"
+ "github.com/apache/arrow/go/v17/arrow/memory"
"github.com/golang/protobuf/ptypes/wrappers"
"github.com/stretchr/testify/suite"
"golang.org/x/exp/maps"
Review Comment:
as a separate change, we might be able to swap out `golang.org/x/exp/maps` for just `maps` now that we've updated the Go version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796#discussion_r1585753806
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -39,13 +39,13 @@ import (
driver "github.com/apache/arrow-adbc/go/adbc/driver/flightsql"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
"github.com/apache/arrow-adbc/go/adbc/validation"
- "github.com/apache/arrow/go/v16/arrow"
- "github.com/apache/arrow/go/v16/arrow/array"
- "github.com/apache/arrow/go/v16/arrow/flight"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql/schema_ref"
- flightproto "github.com/apache/arrow/go/v16/arrow/flight/gen/flight"
- "github.com/apache/arrow/go/v16/arrow/memory"
+ "github.com/apache/arrow/go/v17/arrow"
+ "github.com/apache/arrow/go/v17/arrow/array"
+ "github.com/apache/arrow/go/v17/arrow/flight"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql/schema_ref"
+ flightproto "github.com/apache/arrow/go/v17/arrow/flight/gen/flight"
+ "github.com/apache/arrow/go/v17/arrow/memory"
"github.com/golang/protobuf/ptypes/wrappers"
"github.com/stretchr/testify/suite"
"golang.org/x/exp/maps"
Review Comment:
sure, but are we using any of the features they removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796#discussion_r1585756679
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -39,13 +39,13 @@ import (
driver "github.com/apache/arrow-adbc/go/adbc/driver/flightsql"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
"github.com/apache/arrow-adbc/go/adbc/validation"
- "github.com/apache/arrow/go/v16/arrow"
- "github.com/apache/arrow/go/v16/arrow/array"
- "github.com/apache/arrow/go/v16/arrow/flight"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql/schema_ref"
- flightproto "github.com/apache/arrow/go/v16/arrow/flight/gen/flight"
- "github.com/apache/arrow/go/v16/arrow/memory"
+ "github.com/apache/arrow/go/v17/arrow"
+ "github.com/apache/arrow/go/v17/arrow/array"
+ "github.com/apache/arrow/go/v17/arrow/flight"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql/schema_ref"
+ flightproto "github.com/apache/arrow/go/v17/arrow/flight/gen/flight"
+ "github.com/apache/arrow/go/v17/arrow/memory"
"github.com/golang/protobuf/ptypes/wrappers"
"github.com/stretchr/testify/suite"
"golang.org/x/exp/maps"
Review Comment:
we are, that's why we can't :grimacing:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(go/adbc/driver/flightsql): support stateless prepared statements [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1796:
URL: https://github.com/apache/arrow-adbc/pull/1796#discussion_r1585717089
##########
go/adbc/driver/flightsql/flightsql_adbc_server_test.go:
##########
@@ -39,13 +39,13 @@ import (
driver "github.com/apache/arrow-adbc/go/adbc/driver/flightsql"
"github.com/apache/arrow-adbc/go/adbc/driver/internal"
"github.com/apache/arrow-adbc/go/adbc/validation"
- "github.com/apache/arrow/go/v16/arrow"
- "github.com/apache/arrow/go/v16/arrow/array"
- "github.com/apache/arrow/go/v16/arrow/flight"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql"
- "github.com/apache/arrow/go/v16/arrow/flight/flightsql/schema_ref"
- flightproto "github.com/apache/arrow/go/v16/arrow/flight/gen/flight"
- "github.com/apache/arrow/go/v16/arrow/memory"
+ "github.com/apache/arrow/go/v17/arrow"
+ "github.com/apache/arrow/go/v17/arrow/array"
+ "github.com/apache/arrow/go/v17/arrow/flight"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql"
+ "github.com/apache/arrow/go/v17/arrow/flight/flightsql/schema_ref"
+ flightproto "github.com/apache/arrow/go/v17/arrow/flight/gen/flight"
+ "github.com/apache/arrow/go/v17/arrow/memory"
"github.com/golang/protobuf/ptypes/wrappers"
"github.com/stretchr/testify/suite"
"golang.org/x/exp/maps"
Review Comment:
We can't, they took out some of the exp features
https://github.com/golang/go/issues/61538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org