[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2608: Accumulo Start JUnit5 conversion

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2608:
URL: https://github.com/apache/accumulo/pull/2608#discussion_r847713986


##########
start/src/test/java/org/apache/accumulo/start/classloader/vfs/AccumuloVFSClassLoaderTest.java:
##########
@@ -19,21 +19,22 @@
 package org.apache.accumulo.start.classloader.vfs;
 
 import static java.nio.charset.StandardCharsets.UTF_8;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertTrue;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.File;
 import java.io.FileWriter;
 import java.net.URLClassLoader;
+import java.util.Objects;
 
 import org.apache.accumulo.start.classloader.AccumuloClassLoader;
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.vfs2.FileSystemManager;
 import org.apache.commons.vfs2.impl.VFSClassLoader;
-import org.junit.Rule;
+// import org.junit.jupiter.api.Test;
 import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.io.TempDir;

Review Comment:
   This test can't use Jupiter APIs, because it uses PowerMock. It needs to stick to the vintage APIs, which we might need to keep in the pom.xml alongside the jupiter API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org