You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/24 21:13:23 UTC

[GitHub] [helix] pkuwm opened a new pull request #1309: Fix routingDataSourceType not configured in helix rest

pkuwm opened a new pull request #1309:
URL: https://github.com/apache/helix/pull/1309

### Issues

- [ ] My PR addresses the following Helix issues and references them in the PR description:

Fixes #1308

### Description

- [ ] Here are some details about my PR, including screenshots of any UI changes:

Routing data source type is not set in helix rest when creating a realm-aware zkclient. This PR sets the source type to HTTP in helix rest.

### Tests

- [ ] The following tests are written for this issue:

(List the names of added unit/integration tests)

- [ ] The following is the result of the "mvn test" command on the appropriate module:

(Before CI test pass, please copy & paste the result of "mvn test")

### Documentation (Optional)

- In case of new functionality, my PR adds documentation in the following wiki page:

(Link the GitHub wiki you added)

### Commits

- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"

### Code Quality

- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm commented on pull request #1309: Fix routingDataSourceType not configured in helix rest

Posted by GitBox <gi...@apache.org>.

pkuwm commented on pull request #1309:
URL: https://github.com/apache/helix/pull/1309#issuecomment-679410728


   Verified it works after this change. 
   ```
   {
     "MULTI_ZK_ENABLED" : "true",
     "IS_DEFAULT" : "false",
     "MSDS_ENDPOINT" : "http://<rest-server>/admin/v2/namespaces/test",
     "NAME" : "test"
   }
   
   curl localhost:8100/admin/v2/namespaces/test/clusters                
   {
     "clusters" : [ "cluster-1", "cluster-2"]
   }
   ```
   
   The reason why we don’t catch the defect in helix rest tests is we don’t run tests against multiZk enabled. I think we should do so. We'll enable this in another PR.
   
   This PR is ready to be merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org

[GitHub] [helix] pkuwm merged pull request #1309: Fix routingDataSourceType not configured in helix rest

Posted by GitBox <gi...@apache.org>.

pkuwm merged pull request #1309:
URL: https://github.com/apache/helix/pull/1309


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org