You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "dkuppitz (GitHub)" <gi...@apache.org> on 2019/01/16 21:25:12 UTC
[GitHub] [tinkerpop] dkuppitz opened pull request #1041:
TINKERPOP-2125 Extend release validation script
https://issues.apache.org/jira/browse/TINKERPOP-2125
Added source file check in release validation script.
VOTE +/-0
At this point, the validation does not pass. We need to make a decision on what to do with the following files:
```
./docs/static/images/gremlin-characters.pdf
./docs/static/images/gremlintron.pdf
./docs/static/images/gremlin-sacks.pdf
./docs/static/images/gremlin-gym.pdf
```
Do we whitelist them or should they be removed from the repository?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on issue #1041:
TINKERPOP-2125 Extend release validation script
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
PDFs are now whitelisted and the validation passes.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz closed pull request #1041:
TINKERPOP-2125 Extend release validation script
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
[ pull request closed by dkuppitz ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1041:
TINKERPOP-2125 Extend release validation script
Posted by "spmallette (GitHub)" <gi...@apache.org>.
I'm not sure what those are.............i assume they are just high-res versions of the png files of the same name? i guess i would just whitelist them since they've been there forever at this point. i assume we can allow *.pdf (we're really trying to mostly avoid compiled code like `.exe`, `.dll`, `.jar`, etc)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1041:
TINKERPOP-2125 Extend release validation script
Posted by "spmallette (GitHub)" <gi...@apache.org>.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1041 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org