[jira] [Commented] (NIFI-3631) Memory Leak in SimpleIndexManager

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-3631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15937167#comment-15937167 ] 

ASF GitHub Bot commented on NIFI-3631:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/1613

    NIFI-3631: Do not change Active Directory in IndexDirectoryManager wh…

    …en it becomes full. Instead, wait until it is committed and is removed by the onIndexCommitted method. This resolved a bug where the index can exceed the configured limit but not yet be committed and as a result would no longer be the active index. As a result, this bug causes the IndexWriter never to get closed/removed from the IndexManager, and so a memory leak is created
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-3631

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1613.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1613
    
----
commit e1fc6c4fa4463ced96b11876bc93e88ae7ff427a
Author: Mark Payne <ma...@hotmail.com>
Date:   2017-03-20T21:18:01Z

    NIFI-3631: Do not change Active Directory in IndexDirectoryManager when it becomes full. Instead, wait until it is committed and is removed by the onIndexCommitted method. This resolved a bug where the index can exceed the configured limit but not yet be committed and as a result would no longer be the active index. As a result, this bug causes the IndexWriter never to get closed/removed from the IndexManager, and so a memory leak is created

----


> Memory Leak in SimpleIndexManager
> ---------------------------------
>
>                 Key: NIFI-3631
>                 URL: https://issues.apache.org/jira/browse/NIFI-3631
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Critical
>             Fix For: 1.2.0
>
>
> The SimpleIndexManager in the Provenance Repositories appears to leak instances of LuceneEventIndexWriter:
> [nifi@machine current]$ jmap -histo:live 31598 | grep LuceneEventIndexWriter
>  470:          1267          30408  org.apache.nifi.provenance.lucene.LuceneEventIndexWriter$CommitStats
> 1266:            42           1680  org.apache.nifi.provenance.lucene.LuceneEventIndexWriter
> We should have 1-2 Index Writers per prov partition, and this node has 2 prov partitions but we see 42 instances of the LuceneEventIndexWriter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)