[GitHub] [fineract] vidakovic commented on pull request #2055: FINERACT-1515 Allow multi-disbursements without setting up expected tranche details

[GitBox <gi...@apache.org>]

vidakovic commented on pull request #2055:
URL: https://github.com/apache/fineract/pull/2055#issuecomment-1057534980


   @johnw65 ... code changes look good to me... only thing complaining here are the style checks (tabs vs. spaces, curly braces position etc.). Executing the following command should help with most (if not all) of them:
   ```
   ./gradlew spotlessApply
   ```
   The only thing (I am aware of) that is not solved automatically are "badly" formatted imports (aka Asterisk imports like `org.apache.fineract.*`). Just saying, if you come across those then you have to fix them manually (or use your IDE formatter with proper configuration if available).
   
   I guess you use Eclipse? Here are some useful configs you can use with respective Eclipse plugins:
   
   - Checkstyle: https://github.com/apache/fineract/blob/develop/config/checkstyle/checkstyle.xml
   - Eclipse code formatter: https://github.com/apache/fineract/blob/develop/config/fineractdev-formatter.xml
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org