You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2018/01/27 01:40:15 UTC
Review Request 65366: Added test for maintenance-related offer
rescinding behavior.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65366/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7882
https://issues.apache.org/jira/browse/MESOS-7882
Repository: mesos
Description
-------
This test checks that offers related to a maintenance schedule will
be rescinded when a relevant maintanence schedule is posted or cleared.
The test also checks that un-related offers are not affected.
Diffs
-----
src/tests/master_maintenance_tests.cpp 2a0625873b4f9b6350c14e8304a8d6fbd6a45e6b
Diff: https://reviews.apache.org/r/65366/diff/1/
Testing
-------
make check
This test should fail until the chain is fully applied.
Thanks,
Joseph Wu
Re: Review Request 65366: Added test for maintenance-related offer
rescinding behavior.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65366/#review196403
-----------------------------------------------------------
Ship it!
src/tests/master_maintenance_tests.cpp
Lines 592 (patched)
<https://reviews.apache.org/r/65366/#comment276022>
Any reason you needed this?
src/tests/master_maintenance_tests.cpp
Lines 706 (patched)
<https://reviews.apache.org/r/65366/#comment276023>
secondReplacementOffer?
- Benjamin Mahler
On Jan. 27, 2018, 1:40 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65366/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2018, 1:40 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7882
> https://issues.apache.org/jira/browse/MESOS-7882
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test checks that offers related to a maintenance schedule will
> be rescinded when a relevant maintanence schedule is posted or cleared.
> The test also checks that un-related offers are not affected.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp 2a0625873b4f9b6350c14e8304a8d6fbd6a45e6b
>
>
> Diff: https://reviews.apache.org/r/65366/diff/1/
>
>
> Testing
> -------
>
> make check
>
> This test should fail until the chain is fully applied.
>
>
> Thanks,
>
> Joseph Wu
>
>