[GitHub] [druid] clintropolis opened a new pull request #11925: only get bitmap index for string dictionary encoded columns

[GitBox <gi...@apache.org>]

clintropolis opened a new pull request #11925:
URL: https://github.com/apache/druid/pull/11925


   ### Description
   Follow-up to #11829, this PR adds safeguards to prevent using `BitmapIndex` (which still relies on the underlying column using a String typed dictionary) from being used directly for non-virtual columns that are dictionary encoded, but not String typed. Virtual columns may still provide bitmap indexes, but only dictionary encoded string columns will supply them directly from the column after the changes of this patch.
   
   We should be able to remove these in the future if we modify filtering to be more friendly to non-string types, but until then this will prevent funny class cast exceptions when filters notice that a column has a bitmap and so will use it, but then fail when actually trying to use them.
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `ColumnSelectorBitmapIndexSelector`
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm merged pull request #11925: only get bitmap index for string dictionary encoded columns

[GitBox <gi...@apache.org>]

gianm merged pull request #11925:
URL: https://github.com/apache/druid/pull/11925


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org