You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/11/18 22:52:48 UTC
Review Request 40454: Add calls to parent teardown methods in child
teardown methods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
Bugs: MESOS-3753
https://issues.apache.org/jira/browse/MESOS-3753
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/tests/containerizer/isolator_tests.cpp 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd
src/tests/containerizer/provisioner_docker_tests.cpp edfbb6fe932173dcbb15133e0eb685d86dd09c00
src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9
src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e
Diff: https://reviews.apache.org/r/40454/diff/
Testing
-------
Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
Then:
`make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
Thanks,
Joseph Wu
Re: Review Request 40454: Add calls to parent teardown methods in
child teardown methods.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/#review107109
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40453, 40454]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40454/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 9:52 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd
> src/tests/containerizer/provisioner_docker_tests.cpp edfbb6fe932173dcbb15133e0eb685d86dd09c00
> src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9
> src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e
>
> Diff: https://reviews.apache.org/r/40454/diff/
>
>
> Testing
> -------
>
> Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
>
> Then:
> `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
>
> The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40454: Add calls to parent teardown methods in
child teardown methods.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/#review108375
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Schlicht
On Nov. 30, 2015, 7:15 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40454/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 7:15 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till Toenshoff.
>
>
> Bugs: MESOS-3975
> https://issues.apache.org/jira/browse/MESOS-3975
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/provisioner_docker_tests.cpp b98461e65c2d6e97bce8e7906b4cba87d8bfd35c
> src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd
> src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0
>
> Diff: https://reviews.apache.org/r/40454/diff/
>
>
> Testing
> -------
>
> Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
>
> Then:
> `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
>
> The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40454: Add calls to parent teardown methods in
child teardown methods.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 10:15 a.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Till Toenshoff.
Changes
-------
Rebase (1 conflict)!
Bugs: MESOS-3975
https://issues.apache.org/jira/browse/MESOS-3975
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/tests/containerizer/provisioner_docker_tests.cpp b98461e65c2d6e97bce8e7906b4cba87d8bfd35c
src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd
src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0
Diff: https://reviews.apache.org/r/40454/diff/
Testing
-------
Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
Then:
`make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
Thanks,
Joseph Wu
Re: Review Request 40454: Add calls to parent teardown methods in
child teardown methods.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/#review108346
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40454/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 9:52 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd
> src/tests/containerizer/provisioner_docker_tests.cpp edfbb6fe932173dcbb15133e0eb685d86dd09c00
> src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9
> src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e
>
> Diff: https://reviews.apache.org/r/40454/diff/
>
>
> Testing
> -------
>
> Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
>
> Then:
> `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
>
> The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 40454: Add calls to parent teardown methods in
child teardown methods.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40454/#review108332
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Nov. 18, 2015, 9:52 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40454/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2015, 9:52 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
>
>
> Bugs: MESOS-3753
> https://issues.apache.org/jira/browse/MESOS-3753
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/tests/containerizer/isolator_tests.cpp 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd
> src/tests/containerizer/provisioner_docker_tests.cpp edfbb6fe932173dcbb15133e0eb685d86dd09c00
> src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9
> src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e
>
> Diff: https://reviews.apache.org/r/40454/diff/
>
>
> Testing
> -------
>
> Picked https://reviews.apache.org/r/40268/ which exposes the bad cleanup after SSL-reinitializing tests.
>
> Then:
> `make check GTEST_FILTER="*RegistryClientTest*:*ExecutorHttpApiTest*"`
>
> The `RegistryClientTest` involve some reinitialization of SSL variables. The `ExecutorHttpApiTest` spawns sockets. If the SSL variables are not cleaned up, the second test will try to use SSL sockets against non-SSL endpoints.
>
>
> Thanks,
>
> Joseph Wu
>
>