[GitHub] [maven-jar-plugin] olamy commented on a diff in pull request #47: Code simplifications

[GitBox <gi...@apache.org>]

olamy commented on code in PR #47:
URL: https://github.com/apache/maven-jar-plugin/pull/47#discussion_r942293720


##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -196,16 +196,17 @@ protected File getJarFile( File basedir, String resultFinalName, String classifi
             throw new IllegalArgumentException( "finalName is not allowed to be null" );
         }
 
-        StringBuilder fileName = new StringBuilder( resultFinalName );
-
+        final String fileName;

Review Comment:
   not sure what is the need if final here?



##########
src/main/java/org/apache/maven/plugins/jar/AbstractJarMojo.java:
##########
@@ -243,18 +244,11 @@ public File createArchive()
             }
         }
 
+        final String archiverName = containsModuleDescriptor ? "mjar" : "jar";

Review Comment:
   why final? no real need of this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org