You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@texera.apache.org by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org> on 2025/09/29 16:52:35 UTC
[PR] chore(config): enable user system by default [texera]
Xiao-zhen-Liu opened a new pull request, #3782:
URL: https://github.com/apache/texera/pull/3782
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3782:
URL: https://github.com/apache/texera/pull/3782#discussion_r2403778401
##########
core/scripts/sql/texera_ddl.sql:
##########
@@ -15,18 +15,29 @@
-- specific language governing permissions and limitations
-- under the License.
+-- ============================================
Review Comment:
Is that necessary? We don't run test cases on deployments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on PR #3782:
URL: https://github.com/apache/texera/pull/3782#issuecomment-3367582263
> Is it possible to include a diagram to visualize the change?
I will include a diagram about the behaviors of these test cases in relation to Singleton classes and the databases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3782:
URL: https://github.com/apache/texera/pull/3782#issuecomment-3369579282
I will review this PR after PR #3824 is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #3782:
URL: https://github.com/apache/texera/pull/3782#discussion_r2404120212
##########
core/scripts/sql/texera_ddl.sql:
##########
@@ -15,18 +15,29 @@
-- specific language governing permissions and limitations
-- under the License.
+-- ============================================
Review Comment:
Sure, I will solve #3823 seperately. This change is not needed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #3782:
URL: https://github.com/apache/texera/pull/3782#discussion_r2403787675
##########
core/scripts/sql/texera_ddl.sql:
##########
@@ -15,18 +15,29 @@
-- specific language governing permissions and limitations
-- under the License.
+-- ============================================
Review Comment:
Maintaining two DDL files for every change is a significant burden for developers. We should address issue #3823.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #3782:
URL: https://github.com/apache/texera/pull/3782#issuecomment-3367562589
Is it possible to include a diagram to visualize the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu commented on PR #3782:
URL: https://github.com/apache/texera/pull/3782#issuecomment-3367564425
> Do we want to remove the user-system flag directly? Does user-system = false still work after this PR? If it doesn't work, I suggest we just remove it.
That would be the next PR. It would be too many changes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "bobbai00 (via GitHub)" <gi...@apache.org>.
bobbai00 commented on code in PR #3782:
URL: https://github.com/apache/texera/pull/3782#discussion_r2403775916
##########
core/scripts/sql/texera_ddl.sql:
##########
@@ -15,18 +15,29 @@
-- specific language governing permissions and limitations
-- under the License.
+-- ============================================
Review Comment:
Can you also sync this change to `texera_ddl.sql` under the `deployment` folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "Xiao-zhen-Liu (via GitHub)" <gi...@apache.org>.
Xiao-zhen-Liu merged PR #3782:
URL: https://github.com/apache/texera/pull/3782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(amber): enable user system by default [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #3782:
URL: https://github.com/apache/texera/pull/3782#issuecomment-3367560568
Do we want to remove the user-system flag directly? Does user-system = false still work after this PR? If it doesn't work, I suggest we just remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org