You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2018/11/08 20:32:44 UTC
[Issue 127929] New: Possible crash in Freetype code
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Issue ID: 127929
Issue Type: DEFECT
Summary: Possible crash in Freetype code
Product: General
Version: 4.2.0-dev
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: Normal
Priority: P5 (lowest)
Component: code
Assignee: issues@openoffice.apache.org
Reporter: ardovm@yahoo.it
Target Milestone: ---
Created attachment 86540
--> https://bz.apache.org/ooo/attachment.cgi?id=86540&action=edit
Check the return value of the FT_Get_Glyph() function
Method FreetypeServerFont::InitGlyphData() calls function FT_Get_Glyph() but
does not check its return value.
On my system, the function fails when selecting the ``slide master'' in
Impress, and the program crashes because the method continues with invalid
data.
The attached patch repeats the same check as the previous call to
FT_Load_Glyph().
Please note I have no idea what a glyph is, what those FT_ functions do, and
why they fail. But the attached patch solves the crashes on my systems (tested
on Linux) and looks logical IMHO.
I suppose the same problem is present in version 4.1.5 (Linux and FreeBSD),
because it also crashes when selecting the slide master view.
Please let me know if you need any more information.
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Peter <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |apache@resellerdesktop.de
--- Comment #12 from Peter <pe...@apache.org> ---
*** Issue 128193 has been marked as a duplicate of this issue. ***
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"mseidel" committed SVN revision 1846349 into trunk:
i127929 - Fix for crash in Freetype code
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #5 from Matthias Seidel <ms...@apache.org> ---
Hi Pedro,
Please do not set an issue to RESOLVED/FIXED before the patch is in the code.
But we can leave it for now, as I plan to commit it to trunk soon...
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #9 from Pedro <pe...@gmail.com> ---
> Sorry, this is *not* fixed in 4.1.6.
> Unfortunately this patch was too late for the release in process...
I meant that the patch worked in 4.1.6 and the problem was fixed.
It is unfortunate that it wasn't included in 4.1.6
> But I can confirm that this is fixed in trunk with latest build from
> buildbot on Ubuntu 18.04.1 x64.
Excellent!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Peter <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |petko@apache.org
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #2 from Peter <pe...@apache.org> ---
Thanks a lot for the patch, we Try and come back for feedback :)
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #4 from Arrigo Marchiori <ar...@yahoo.it> ---
(In reply to Pedro from comment #3)
> Thank you Arrigo Marchiori for fixing this crasher!
You are welcome!
Please excuse me if the question is silly, but why did you mark it
resolved-fixed if trunk is still affected?
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
mechtilde <oo...@mechtilde.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |crash
Priority|P5 (lowest) |P2
CC| |ooo@mechtilde.de
--- Comment #10 from mechtilde <oo...@mechtilde.de> ---
set new importance
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pescetti@apache.org
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #7 from Pedro <pe...@gmail.com> ---
(In reply to Arrigo Marchiori from comment #4)
> Please excuse me if the question is silly, but why did you mark it
> resolved-fixed if trunk is still affected?
I do not know if trunk is still affected. I could not compile and test a binary
from trunk. What I do know is that it is fixed in the 4.1.6 branch which is the
one we are currently testing. Hopefully it will be fixed on trunk as well :)
Since Matthias has committed your patch to trunk, I can test it soon.
(In reply to Matthias Seidel from comment #5)
> Hi Pedro,
>
> Please do not set an issue to RESOLVED/FIXED before the patch is in the code.
>
> But we can leave it for now, as I plan to commit it to trunk soon...
Sorry! Thanks!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Peter <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mseidel@apache.org
--- Comment #1 from Peter <pe...@apache.org> ---
*** Issue 127805 has been marked as a duplicate of this issue. ***
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|4.2.0 |4.1.7
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
--- Comment #8 from Matthias Seidel <ms...@apache.org> ---
(In reply to Pedro from comment #7)
> (In reply to Arrigo Marchiori from comment #4)
>
> > Please excuse me if the question is silly, but why did you mark it
> > resolved-fixed if trunk is still affected?
>
> I do not know if trunk is still affected. I could not compile and test a
> binary from trunk. What I do know is that it is fixed in the 4.1.6 branch
> which is the one we are currently testing. Hopefully it will be fixed on
> trunk as well :)
Hi Pedro,
Sorry, this is *not* fixed in 4.1.6.
Unfortunately this patch was too late for the release in process...
> Since Matthias has committed your patch to trunk, I can test it soon.
But I can confirm that this is fixed in trunk with latest build from buildbot
on Ubuntu 18.04.1 x64.
Regards, Matthias
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS|All |Linux, all
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Pedro <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
CC| |pedlino@gmail.com
Version|4.2.0-dev |4.1.5
--- Comment #3 from Pedro <pe...@gmail.com> ---
Thank you Arrigo Marchiori for fixing this crasher!
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Peter <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.2.0
Version|4.2.0-dev |4.1.6
--- Comment #11 from Peter <pe...@apache.org> ---
backdate to 4.1.6 and target milestone is 4.2.0 / 4.1.7 (when it gets done)
--
You are receiving this mail because:
You are the assignee for the issue.
[Issue 127929] Possible crash in Freetype code
Posted by bu...@apache.org.
https://bz.apache.org/ooo/show_bug.cgi?id=127929
Matthias Seidel <ms...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.1.5 |4.2.0-dev
Latest|--- |4.1.6
Confirmation in| |
--
You are receiving this mail because:
You are the assignee for the issue.