You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/03/17 19:52:33 UTC
[GitHub] [guacamole-client] Vict0rC opened a new pull request #484:
GUACAMOLE-781: Translation updated, filename fixed
Vict0rC opened a new pull request #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484
GUACAMOLE-781: Translation updated based on latest en.json and filename fixed to cs.json
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] Vict0rC commented on a change in pull request
#484: GUACAMOLE-781: Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
Vict0rC commented on a change in pull request #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484#discussion_r394182169
##########
File path: guacamole/src/main/webapp/translations/cs.json
##########
@@ -42,8 +42,9 @@
"INFO_ACTIVE_USER_COUNT" : "V současné době používá {USERS} {USERS, plural, one{user} other{users}}.",
- "TEXT_ANONYMOUS_USER" : "Anonym",
- "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}"
+ "TEXT_ANONYMOUS_USER" : "Neznámý uživatel",
+ "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}",
Review comment:
Offf, sorry, missed it! Fixed! :-) thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] Vict0rC commented on a change in pull request
#484: GUACAMOLE-781: Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
Vict0rC commented on a change in pull request #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484#discussion_r394182169
##########
File path: guacamole/src/main/webapp/translations/cs.json
##########
@@ -42,8 +42,9 @@
"INFO_ACTIVE_USER_COUNT" : "V současné době používá {USERS} {USERS, plural, one{user} other{users}}.",
- "TEXT_ANONYMOUS_USER" : "Anonym",
- "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}"
+ "TEXT_ANONYMOUS_USER" : "Neznámý uživatel",
+ "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}",
Review comment:
Ohhh, sorry, missed it! Fixed! :-) thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on a change in pull
request #484: GUACAMOLE-781: Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on a change in pull request #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484#discussion_r393992623
##########
File path: guacamole/src/main/webapp/translations/cs.json
##########
@@ -42,8 +42,9 @@
"INFO_ACTIVE_USER_COUNT" : "V současné době používá {USERS} {USERS, plural, one{user} other{users}}.",
- "TEXT_ANONYMOUS_USER" : "Anonym",
- "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}"
+ "TEXT_ANONYMOUS_USER" : "Neznámý uživatel",
+ "TEXT_HISTORY_DURATION" : "{VALUE} {UNIT, select, second{{VALUE, plural, one{second} other{seconds}}} minute{{VALUE, plural, one{minute} other{minutes}}} hour{{VALUE, plural, one{hour} other{hours}}} day{{VALUE, plural, one{day} other{days}}} other{}}",
Review comment:
This will result in the English words for these units and the English plurals being used (second/seconds, minute/minutes, etc.). Is this intentional?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper commented on issue #484:
GUACAMOLE-781: Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
mike-jumper commented on issue #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484#issuecomment-600318797
Thanks, @Vict0rC, this looks much better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] Vict0rC commented on issue #484: GUACAMOLE-781:
Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
Vict0rC commented on issue #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484#issuecomment-600270952
I apologize for the confusion, hopefully everything is fine now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [guacamole-client] mike-jumper merged pull request #484:
GUACAMOLE-781: Translation updated, filename fixed
Posted by GitBox <gi...@apache.org>.
mike-jumper merged pull request #484: GUACAMOLE-781: Translation updated, filename fixed
URL: https://github.com/apache/guacamole-client/pull/484
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services