[jira] [Work logged] (TS-4650) cachekey: not thread safe

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4650?focusedWorklogId=31452&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31452 ]

ASF GitHub Bot logged work on TS-4650:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Nov/16 18:19
            Start Date: 02/Nov/16 18:19
    Worklog Time Spent: 10m 
      Work Description: GitHub user gtenev opened a pull request:

    https://github.com/apache/trafficserver/pull/1172

    TS-4650: cachekey: not thread safe

    (cherry picked from commit f4a97a9d573867441c5dd711b54ff66117fcd057)
    (cherry picked from commit 15b2ab08a30a0df8c2223e05c7bfc4cb530ea243)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gtenev/trafficserver TS-4650_backport

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1172
    
----
commit ec577b957b75a2a0e1e481d47f2e3f5988c21f1e
Author: Felicity Tarnell <ft...@le-fay.org>
Date:   2016-07-12T15:28:44Z

    TS-4650: cachekey: not thread safe
    
    (cherry picked from commit f4a97a9d573867441c5dd711b54ff66117fcd057)
    (cherry picked from commit 15b2ab08a30a0df8c2223e05c7bfc4cb530ea243)

----


Issue Time Tracking
-------------------

    Worklog Id:     (was: 31452)
    Time Spent: 2h  (was: 1h 50m)

> cachekey: not thread safe
> -------------------------
>
>                 Key: TS-4650
>                 URL: https://issues.apache.org/jira/browse/TS-4650
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>    Affects Versions: 6.2.0
>            Reporter: Felicity Tarnell
>            Assignee: Felicity Tarnell
>             Fix For: 7.0.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> cachekey's Pattern class is not thread safe; it uses member data to store the result of pcre_exec(), but only one instance is shared between all threads.  This causes crashes when two threads access the pcre result at the same time.
> Fix: use automatic storage for the pcre result data.
> PR incoming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)