[spark] branch master updated: [SPARK-43206][SS][CONNECT][FOLLOWUP] Remove unintended change on `StreamingQueryManager.scala`

[do...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new c4feb97eaa4 [SPARK-43206][SS][CONNECT][FOLLOWUP] Remove unintended change on `StreamingQueryManager.scala`
c4feb97eaa4 is described below

commit c4feb97eaa4ce33a45d8eead4eab8b4c17ffbcc4
Author: Wei Liu <we...@databricks.com>
AuthorDate: Mon May 1 15:07:51 2023 -0700

    [SPARK-43206][SS][CONNECT][FOLLOWUP] Remove unintended change on `StreamingQueryManager.scala`
    
    ### What changes were proposed in this pull request?
    
    https://github.com/apache/spark/pull/40966 introduced a unneeded change in `StreamingQueryManager` by error. This fix removes it.
    
    ### Why are the changes needed?
    
    Bug fix
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Existing tests
    
    Closes #41006 from WweiL/minor-sqm-uncomment.
    
    Authored-by: Wei Liu <we...@databricks.com>
    Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
 .../scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala b/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
index 23d05a0a210..20254dec3d8 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryManager.scala
@@ -408,7 +408,7 @@ class StreamingQueryManager private[sql] (
       query.streamingQuery.start()
     } catch {
       case e: Throwable =>
-//        unregisterTerminatedStream(query)
+        unregisterTerminatedStream(query)
         throw e
     }
     query
@@ -416,7 +416,7 @@ class StreamingQueryManager private[sql] (
 
   /** Notify (by the StreamingQuery) that the query has been terminated */
   private[sql] def notifyQueryTermination(terminatedQuery: StreamingQuery): Unit = {
-//    unregisterTerminatedStream(terminatedQuery)
+    unregisterTerminatedStream(terminatedQuery)
     awaitTerminationLock.synchronized {
       if (lastTerminatedQueryException == null || terminatedQuery.exception.nonEmpty) {
         lastTerminatedQueryException = terminatedQuery.exception


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org